[Kernel] Use call_jax to simplify the gmm pallas kernel wrapper #9180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The background is there's a PR vllm-project/vllm#18025 trying to enable torch_xla gmm kernel but encountered correctness issue. Simplifying the wrapper to use |
|
also cc @bythew3i for visibility, seems I cannot add you as a reviewer. |
vanbasten23
reviewed
May 16, 2025
vanbasten23
reviewed
May 16, 2025
vanbasten23
reviewed
May 16, 2025
yaochengji
force-pushed
the
chengji/gmm-use-call_jax
branch
from
b796514 to
27a4c0a
Compare
vanbasten23
reviewed
May 16, 2025
vanbasten23
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.