Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported data formats in documentation #123

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Update supported data formats in documentation #123

merged 2 commits into from
Jun 26, 2023

Conversation

sfinkens
Copy link
Member

@sfinkens sfinkens commented May 31, 2023

Add a note that 10 bits/pixel are required.

Closes pytroll/satpy#2494

@sfinkens sfinkens requested a review from mraspaud May 31, 2023 16:00
@sfinkens sfinkens self-assigned this May 31, 2023
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but two things:

  • Should we add a screenshot of the downloading interface here?
  • Should we make sure the satpy reader doc states the same?

@sfinkens
Copy link
Member Author

sfinkens commented Jun 6, 2023

Should we make sure the satpy reader doc states the same?

Good idea! -> pytroll/satpy#2501

@sfinkens
Copy link
Member Author

Should we add a screenshot of the downloading interface here?

Added a screenshot.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #123 (d7770f3) into main (748774e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   74.39%   74.39%           
=======================================
  Files          32       32           
  Lines        2882     2882           
=======================================
  Hits         2144     2144           
  Misses        738      738           

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 7900539 into main Jun 26, 2023
9 checks passed
@mraspaud mraspaud deleted the update-doc branch June 26, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avhrr_l1b_gaclac fails to read most files from NOAA CLASS
2 participants