Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract calibration modules from the reader #127

Merged
merged 30 commits into from
Aug 30, 2024

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Mar 26, 2024

This PR extracts calibration modules from the reader.

As we are preparing to add new calibration and navigation algorithms for pygac, it needs to be upgraded to be made more modular.

@mraspaud mraspaud self-assigned this Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 98.12734% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.11%. Comparing base (298252f) to head (806fec3).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
pygac/reader.py 95.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   74.22%   76.11%   +1.89%     
==========================================
  Files          33       32       -1     
  Lines        3115     3195      +80     
==========================================
+ Hits         2312     2432     +120     
+ Misses        803      763      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mraspaud mraspaud marked this pull request as ready for review August 28, 2024 10:38
Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I like the entry-point approach. Should have started reading with the tests, they are pretty clear 👍

pygac/calibration/noaa.py Outdated Show resolved Hide resolved
pygac/reader.py Outdated Show resolved Hide resolved
pygac/reader.py Show resolved Hide resolved
pygac/reader.py Show resolved Hide resolved
@mraspaud mraspaud changed the title Extract calibration and navigation modules from the reader Extract calibration modules from the reader Aug 29, 2024
@mraspaud
Copy link
Member Author

@sfinkens if you could review again, that would be great :) I have address all you comment I think, and did some more refactoring. I need to do more, but I will do that in another PR, along with extracting the navigation module.

Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks for all the refactoring effort!

@mraspaud mraspaud merged commit d95d657 into pytroll:main Aug 30, 2024
5 of 6 checks passed
@mraspaud mraspaud deleted the refactor-calibration branch August 30, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants