-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ci to 3.13 #633
base: main
Are you sure you want to change the base?
Upgrade ci to 3.13 #633
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #633 +/- ##
==========================================
+ Coverage 93.96% 93.97% +0.01%
==========================================
Files 86 86
Lines 13538 13536 -2
==========================================
Hits 12721 12721
+ Misses 817 815 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ok so mypy is failing with
anyone knows what this is about? |
I think I've misused the type For the second error, change the import to |
pyproject.toml
Outdated
@@ -22,7 +22,7 @@ convention = "google" | |||
max-complexity = 10 | |||
|
|||
[tool.mypy] | |||
python_version = "3.9" | |||
python_version = "3.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mypy should do checks based on the oldest supported version of python. So 3.11 in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn’t know that, fixed, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, now mypy is complaining again…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just add type ignores for those lines. It is either numpy or the typeshed type definitions for the standard library's hash stuff that doesn't understand that numpy arrays support the buffer interface.
This PR adds support for python 3.13. This was triggered by the rebuild of pyresample for 3.13 in conda forge.