Fix data promotion in generic_image
reader and satpy.composites.add_bands
#2923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While figuring out why
geo_color
wasfloat64
, I found that bothgeneric_image
reader (used to read background images) andsatpy.composites.add_bands()
were mishandling the data. This fixes these two bugs in one go, as they both are triggered byBackgroundCompositor
for certain cases.Requires also pytroll/trollimage#186 for the
geo_color
to be fully fixed, theinvert
enhancement promotes data tofloat64
when the inversion parameters are given for each channel.The
generic_image
reader tests were converted topytest
.AUTHORS.md
if not there already