Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PyCon TW 2023 video #1142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add PyCon TW 2023 video #1142

wants to merge 1 commit into from

Conversation

allen91wu
Copy link
Contributor

No description provided.

@jonafato
Copy link
Member

jonafato commented Dec 4, 2023

Thank you for this contribution! This looks mostly ready to go, just a few small change requests:

  1. Please delete the pycon-tw-2023/.DS_Store file, as this is an artifact of the OS and not relevant to PyVideo.
  2. Can you remove the conference title from the talk titles in the talk JSON files? I understand that this is useful for search on YouTube, but the events are stored as part of the talk data and linked directly within the talk pages.
  3. When previewing this PR locally, I see the following error message on the YouTube player:

Video unavailable
Playback on other websites has been disabled by the video owner
Watch on YouTube

If you are an owner or manager for this YouTube channel, can you ensure that this content is playable on other sites so that it will be able to be watched on pyvideo.org?

@allen91wu
Copy link
Contributor Author

allen91wu commented Dec 4, 2023 •
edited
Loading

Thanks for your review. I have fixed the problem.
Please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allen91wu @jonafato