Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming CLI argument #92

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

germa89
Copy link
Contributor

@germa89 germa89 commented Oct 2, 2023

Renaming fail_extra_image_cache argument to fail_if_missing_image_cache, since this new name is more self-explanatory. It might be a bit too long. I'm happy to delete the _if part if needed.

@github-actions github-actions bot added the enhancement New feature or request label Oct 2, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #92 (27e1e1a) into main (ba7b24d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files           2        2           
  Lines         100      100           
=======================================
  Hits           96       96           
  Misses          4        4           
Files Coverage Δ
pytest_pyvista/pytest_pyvista.py 95.91% <100.00%> (ø)

@akaszynski
Copy link
Member

@MatthewFlamm, it's your call.

@MatthewFlamm
Copy link
Contributor

I'm +1. I assume there are only a few downstream users of this package. Should we deprecate the old one and make it a temporary alias? I'm fine just hard removing it too given how young this package is.

@germa89
Copy link
Contributor Author

germa89 commented Oct 9, 2023

I would just remove it...

@MaxJPRey
Copy link
Contributor

MaxJPRey commented Oct 9, 2023

I would just remove it too. I will notify people making usage of it in PyAnsys packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants