Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nodata values #35

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Support nodata values #35

wants to merge 1 commit into from

Conversation

banesullivan
Copy link
Member

Potential solution to #34

It's a bit dirty as it modifies the data in place or creates a copy of the integer data to float dtype (potentially expensive).

This is my first pass at this, but I'd like to look into some other ways of going about this that do not have as bad of side effects

cc @giswqs

@banesullivan banesullivan mentioned this pull request Jul 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #35 (0101820) into main (e19eab1) will decrease coverage by 3.85%.
The diff coverage is 52.17%.

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   90.73%   86.87%   -3.86%     
==========================================
  Files           8        8              
  Lines         205      221      +16     
==========================================
+ Hits          186      192       +6     
- Misses         19       29      +10     
Impacted Files Coverage Δ
pvxarray/accessor.py 80.64% <42.10%> (-15.19%) ⬇️
pvxarray/errors.py 100.00% <100.00%> (ø)
pvxarray/rectilinear.py 97.05% <100.00%> (ø)
pvxarray/structured.py 85.29% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants