Skip to content

Commit

Permalink
Fix release workflows (pytorch#3536)
Browse files Browse the repository at this point in the history
Summary:
X-link: facebookresearch/FBGEMM#617

- Add env vars to release workflows to get CUDA 12.6 building correctly

- Install GCC for updated LIBGCC in the release workflows

Pull Request resolved: pytorch#3536

Reviewed By: sryap

Differential Revision: D67774510

Pulled By: q10

fbshipit-source-id: ecf09ae72ba383aa81e5dca02dc46a9b6f5bbea1
  • Loading branch information
q10 authored and facebook-github-bot committed Jan 3, 2025
1 parent 61eda30 commit 3dea957
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/fbgemm_gpu_release_cuda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ jobs:
PRELUDE: .github/scripts/setup_env.bash
BUILD_ENV: build_binary
BUILD_VARIANT: cuda
BUILD_CUDA_VERSION: ${{ matrix.cuda-version }}
continue-on-error: true
strategy:
# Don't fast-fail all the other builds if one of the them fails
Expand Down Expand Up @@ -136,6 +137,7 @@ jobs:
PRELUDE: .github/scripts/setup_env.bash
BUILD_ENV: build_binary
BUILD_VARIANT: cuda
BUILD_CUDA_VERSION: ${{ matrix.cuda-version }}
ENFORCE_CUDA_DEVICE: 1
strategy:
fail-fast: false
Expand Down Expand Up @@ -171,6 +173,13 @@ jobs:
- name: Create Conda Environment
run: . $PRELUDE; create_conda_environment $BUILD_ENV ${{ matrix.python-version }}

- name: Install C/C++ Compilers for Updated LIBGCC
# NOTE: gcc is required for torch dynamo to work properly, as some of
# the compilation flags used by torch dynamo are gcc-specific:
#
# clang-16: error: unknown argument: '-fno-tree-loop-vectorize'
run: . $PRELUDE; install_cxx_compiler $BUILD_ENV gcc

- name: Install CUDA
run: . $PRELUDE; install_cuda $BUILD_ENV ${{ matrix.cuda-version }}

Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/fbgemm_gpu_release_genai.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ jobs:
PRELUDE: .github/scripts/setup_env.bash
BUILD_ENV: build_binary
BUILD_VARIANT: genai
BUILD_CUDA_VERSION: ${{ matrix.cuda-version }}
continue-on-error: true
strategy:
# Don't fast-fail all the other builds if one of the them fails
Expand Down Expand Up @@ -136,6 +137,7 @@ jobs:
PRELUDE: .github/scripts/setup_env.bash
BUILD_ENV: build_binary
BUILD_VARIANT: genai
BUILD_CUDA_VERSION: ${{ matrix.cuda-version }}
ENFORCE_CUDA_DEVICE: 1
strategy:
fail-fast: false
Expand Down Expand Up @@ -171,6 +173,13 @@ jobs:
- name: Create Conda Environment
run: . $PRELUDE; create_conda_environment $BUILD_ENV ${{ matrix.python-version }}

- name: Install C/C++ Compilers for Updated LIBGCC
# NOTE: gcc is required for torch dynamo to work properly, as some of
# the compilation flags used by torch dynamo are gcc-specific:
#
# clang-16: error: unknown argument: '-fno-tree-loop-vectorize'
run: . $PRELUDE; install_cxx_compiler $BUILD_ENV gcc

- name: Install CUDA
run: . $PRELUDE; install_cuda $BUILD_ENV ${{ matrix.cuda-version }}

Expand Down

0 comments on commit 3dea957

Please sign in to comment.