Hw 3.1 #16
Open
Hw 3.1 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
September 15, 2024 01:46
# Conflicts: # niffler-e-2-e-tests/src/test/java/guru/qa/niffler/jupiter/extension/SpendingExtension.java # niffler-e-2-e-tests/src/test/java/guru/qa/niffler/test/web/SpendingWebTest.java
sashkir7
approved these changes
Sep 19, 2024
Comment on lines
+12
to
+13
| private final SelenideElement statisticsHeader = $(".css-giaux5"); | ||
| private final SelenideElement historyHeader = $(".css-uxhuts"); |
There was a problem hiding this comment.
Подобные классы .css-giaux5 лучше не использовать в качестве локаторов - выглядит очень ненадежно (+ скорее всего они формируются динамически, рандомно)
| private final SelenideElement archiveButtonSubmit = $x("//button[text()='Archive']"); | ||
| private final SelenideElement unarchiveButtonSubmit = $x("//button[text()='Unarchive']"); | ||
| private final ElementsCollection categoryList = $$(".MuiChip-root"); | ||
| private final SelenideElement successArchiveMessage = $x("//div[@class='MuiAlert-message css-1xsto0d']"); |
There was a problem hiding this comment.
Опять же класс css-1xsto0d лучше не использовать
Можно просто $("div.MuiAlert-message")
Comment on lines
+27
to
+28
| nameInput.clear(); | ||
| nameInput.setValue(name); |
There was a problem hiding this comment.
Перед setValue() clear() делать не обязательно
Comment on lines
+44
to
+54
| for (int i = 0; i < categoryList.size(); i++) { | ||
| // Проверяем, содержит ли элемент текст категории | ||
| if (categoryList.get(i).text().equals(categoryName)) { | ||
| // Находим кнопку "Архивировать" внутри той же строки с названием категории | ||
| SelenideElement archiveButtonInRow = categoryList.get(i).parent().$(".MuiIconButton-sizeMedium[aria-label='Archive category']"); | ||
| // Кликаем по кнопке архивирования | ||
| archiveButtonInRow.click(); | ||
| break; | ||
| } | ||
| } | ||
| return this; |
There was a problem hiding this comment.
Как правило, писать собственные циклы в page-object классах нам не нужно
За нас все давно уже реализовано. Например, здесь можно воспользоваться filter от Selenide
categoryList.findBy(text(categoryName)) - далее находим кнопку и тыкаем
Comment on lines
+58
to
+68
| // Проходим по списку категорий | ||
| for (int i = 0; i < categoryList.size(); i++) { | ||
| // Проверяем, содержит ли элемент текст имени категории | ||
| if (categoryList.get(i).text().equals(categoryName)) { | ||
| // Находим кнопку "Разархивировать" внутри той же строки с названием категории | ||
| SelenideElement unarchiveButtonInRow = categoryList.get(i).parent().$("[data-testid='UnarchiveOutlinedIcon']"); | ||
| // Кликаем по кнопке разархивирования | ||
| unarchiveButtonInRow.click(); | ||
| break; | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix got hw3.1