Resolving Issue of Helm chart #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jshaktiraj , thanks for the contribution. On the first looks this PR needs quite some rework! You have included a lot of generated and temporary files in the Helm charts/ directory. Also you have changed other vital parameters that have nothing to do with Helm that will break the local deployment. |
|
Hi Reimer,
Thanks for the prompt reply. Yes I know it will require some rework ,
actually I am still learning and want to explore opensource projects with
kubernetes , helm , CI/CD etc. I am really happy to get updates and replies
this quickly. Let me know if I could help in any way I can.
Thanks and regards
Shakti
…On Wed, Nov 9, 2022, 13:08 M.-Leander Reimer ***@***.***> wrote:
Hi @jshaktiraj <https://github.com/jshaktiraj> , thanks for the
contribution. On the first looks this PR needs quite some rework! You have
included a lot of generated and temporary files in the Helm charts/
directory. Also you have changed other vital parameters that have nothing
to do with Helm that will break the local deployment.
—
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APP7WZSCMYE3AUA42RI7OBTWHNIGBANCNFSM6AAAAAAR3DPIWA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created Helm chart as per instruction using Kustohelmize