add Footer & Header clarification to docs #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuri
added
the
size/XS
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1644 +/- ##
=======================================
Coverage 98.91% 98.91%
=======================================
Files 31 31
Lines 26482 26482
=======================================
Hits 26194 26194
Misses 191 191
Partials 97 97
Flags with carried forward coverage won't be shown. Click here to find out more.
|
xuri
approved these changes
Sep 3, 2023
jenbonzhang
pushed a commit
to jenbonzhang/excelize
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
improve documentation related to SetHeaderFooter field use
Description
The existing documentation does not identify the fields to be used when just wanting to set a simple header or footer to the page layout. It is not obvious to folks who are not familiar with the inner data layout of Excel's data structures that 'OddFooter' and 'OddHeader' are overloaded as the primary fields to be referenced if only using one header and footer in the sheet.
Related Issue
Motivation and Context
How Has This Been Tested
Types of changes
Checklist