Skip to content

streaming writer set default value like non-streaming one #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mengpromax
Copy link
Contributor

PR Details

  1. make receiver name of xlsxC unified.
  2. streaming writer can set cell default value like non-streaming one.

Related Issue

#2151

Motivation and Context

We have a legacy impl using the non-streamingly writer to write excel, in which we use setCellDefault func to set raw value.
Now i want to migrate some logic to streaming writer impl, i found no a corresponding impl setCellDefault for steaming write. :)

How Has This Been Tested

  • UT test for pass SetCellDefaultValue to setCellValFunc.
  • Test in our business scenarios.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mengpromax mengpromax changed the title Feat/sw set default value streaming writer set default value like non-streaming one Jun 9, 2025
mengzhongyuan added 2 commits June 9, 2025 22:43
Change-Id: Idd8da825025a3ab046d74380ec36f25091c41560
Signed-off-by: mengzhongyuan <[email protected]>
Change-Id: If019aea806b9527937a9fe8d90050d2ef3d783b0
Signed-off-by: mengzhongyuan <[email protected]>
@mengpromax mengpromax force-pushed the feat/sw_set_default_value branch from 6da209b to d83ae68 Compare June 9, 2025 14:43
…riter

Change-Id: I7b29a679603217d81e566ddc42567a5c369f6bc7
Signed-off-by: mengzhongyuan <[email protected]>
@xuri xuri added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 9, 2025
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.23%. Comparing base (5bd9647) to head (d7ba070).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2152   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files          32       32           
  Lines       30273    30278    +5     
=======================================
+ Hits        30042    30047    +5     
  Misses        153      153           
  Partials       78       78           
Flag Coverage Δ
unittests 99.23% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants