Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed conflict with the names of some stashes. #579

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

hakos47
Copy link
Contributor

@hakos47 hakos47 commented Sep 19, 2024

Description

Checklist

  • I have personally loaded this code into an updated qbcore project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

Copy link
Contributor

@Qwerty1Verified Qwerty1Verified left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- is a special character with pattern matching and should be escaped using % like the PR. I can't think of an example currently other than something like stash-animalshop which would match 'sho' at the end of the string and isn't the desired behaviour.

I'd stick to find though since it's a quicker function and there's no reason to switch to match. Perhaps there's a reason you switched to match?

@hakos47
Copy link
Contributor Author

hakos47 commented Sep 20, 2024

The reason I used match is that I'm more accustomed to using it in these types of situations. However, I agree that find is faster and more efficient for this specific case. It can definitely be done with find as well—it's just a matter of preference for now.

@GhzGarage
Copy link
Member

Do you have some example of this actually doing anything? Technically it shouldn't

@GhzGarage GhzGarage added the question Further information is requested label Oct 17, 2024
@GhzGarage GhzGarage self-assigned this Oct 17, 2024
@Qwerty1Verified
Copy link
Contributor

Qwerty1Verified commented Oct 17, 2024

@GhzGarage take a look at the example I used, I imagine theirs is similar. If they have an example it could provide some insight too.

@hakos47
Copy link
Contributor Author

hakos47 commented Nov 1, 2024

When creating a stash with burgershoot it recognizes it as a store

@GhzGarage GhzGarage merged commit 19c6416 into qbcore-framework:main Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants