-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed conflict with the names of some stashes. #579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
is a special character with pattern matching and should be escaped using %
like the PR. I can't think of an example currently other than something like stash-animalshop
which would match 'sho' at the end of the string and isn't the desired behaviour.
I'd stick to find though since it's a quicker function and there's no reason to switch to match. Perhaps there's a reason you switched to match?
The reason I used match is that I'm more accustomed to using it in these types of situations. However, I agree that find is faster and more efficient for this specific case. It can definitely be done with find as well—it's just a matter of preference for now. |
Do you have some example of this actually doing anything? Technically it shouldn't |
@GhzGarage take a look at the example I used, I imagine theirs is similar. If they have an example it could provide some insight too. |
When creating a stash with burgershoot it recognizes it as a store |
Description
Checklist