Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: item purchasing spawn exploit #603

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

Qwerty1Verified
Copy link
Contributor

Description

This PR fixes an exploit that allows a client to spawn items without the appropriate checks and validation.
To perform this validation, it uses the data given by qb-shops handle checks like checking if the slot given by the client is the same as the slot given by the shop, and rather than using the price given by the client, instead use the price given by the shop.

Checklist

  • I have personally loaded this code into an updated qbcore project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

@GhzGarage GhzGarage merged commit 48ed1ed into qbcore-framework:main Nov 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants