Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locales): add Spanish translations #130

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Cocodrulo
Copy link

Describe Pull request
This PR brings the Spanish locale to the management script.

If your PR is to fix an issue mention that issue here: No

Questions (please complete the following information):

  • Have you personally loaded this code into an updated qbcore project and checked all it's functionality? [no] (But they are just locale it shouldn't be any problem at all)
  • Does your code fit the style guidelines? [yes]
  • Does your PR fit the contribution guidelines? [yes]

Copy link

@IDKFORCE IDKFORCE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should make the spanish more traditional as center as posible like for example
This

 ['exit'] = 'Volver',

Should Be

 ['exit'] = 'Cerrar',

also gestionar empleados could be like manejar empleados
is more central spanish gotta think outside of your dialogue also lots of people use ganga not really banda thats more mexican dialogue

like i would do it like this

local Translations = {
   headers = {
       ['bsm'] = 'Menú de Jefe - ',
   },
   body = {
       ['manage'] = 'Manejar empleados',
       ['managed'] = 'Revisa tu lista de empleados',
       ['hire'] = 'Contratar empleados',
       ['hired'] = 'Contratar civiles cercanos',
       ['storage'] = 'Acceso a almacenamiento',
       ['storaged'] = 'Abrir almacenamiento',
       ['outfits'] = 'Vestimenta',
       ['outfitsd'] = 'Ver vestimenta guardada',
       ['money'] = 'Manejo de dinero',
       ['moneyd'] = 'Revisar el saldo de tu empresa',
       ['mempl'] = 'Manejar empleados - ',
       ['mngpl'] = 'Manejar ',
       ['grade'] = 'Rango: ',
       ['fireemp'] = 'Despedir empleado',
       ['hireemp'] = 'Contratar empleados - ',
       ['cid'] = 'ID de ciudadano: ',
       ['balance'] = 'Saldo: $',
       ['deposit'] = 'Depositar',
       ['depositd'] = 'Depositar dinero en la cuenta',
       ['withdraw'] = 'Retirar',
       ['withdrawd'] = 'Retirar dinero de la cuenta',
       ['depositm'] = 'Depositar dinero <br> Saldo disponible: $',
       ['withdrawm'] = 'Retirar dinero <br> Saldo disponible: $',
       ['submit'] = 'Confirmar',
       ['amount'] = 'Cantidad',
       ['return'] = 'Volver',
       ['exit'] = 'Cerrar',
   },
   drawtext = {
       ['label'] = '[E] Abrir manejo de trabajo',
   },
   target = {
       ['label'] = 'Menú de Jefe',
   },
   headersgang = {
       ['bsm'] = 'Manejo de Ganga - ',
   },
   bodygang = {
       ['manage'] = 'Manejar miembros de la ganga',
       ['managed'] = 'Reclutar o despedir miembros de la ganga',
       ['hire'] = 'Reclutar miembros',
       ['hired'] = 'Contratar miembros de la ganga',
       ['storage'] = 'Acceso a almacenamiento',
       ['storaged'] = 'Abrir Inventario de la ganga',
       ['outfits'] = 'Vestimenta',
       ['outfitsd'] = 'Cambiar de vestimenta',
       ['money'] = 'Manejo de dinero',
       ['moneyd'] = 'Revisar el saldo de tu ganga',
       ['mempl'] = 'Manejar miembros de la ganga - ',
       ['mngpl'] = 'Manejar ',
       ['grade'] = 'Rango: ',
       ['fireemp'] = 'Despedir',
       ['hireemp'] = 'Contratar miembros de la ganga - ',
       ['cid'] = 'ID de ciudadano: ',
       ['balance'] = 'Saldo: $',
       ['deposit'] = 'Depositar',
       ['depositd'] = 'Depositar dinero en la cuenta',
       ['withdraw'] = 'Retirar',
       ['withdrawd'] = 'Retirar dinero de la cuenta',
       ['depositm'] = 'Depositar dinero <br> Saldo disponible: $',
       ['withdrawm'] = 'Retirar dinero <br> Saldo disponible: $',
       ['submit'] = 'Confirmar',
       ['amount'] = 'Cantidad',
       ['return'] = 'Volver',
       ['exit'] = 'Cerrar',
   },
   drawtextgang = {
       ['label'] = '[E] Abrir manejo de la ganga',
   },
   targetgang = {
       ['label'] = 'Menú de la Ganga',
   }
}

if GetConvar('qb_locale', 'en') == 'es' then
   Lang = Lang or Locale:new({
       phrases = Translations,
       warnOnMissing = true
   })
end

@Cocodrulo
Copy link
Author

Cocodrulo commented Nov 14, 2024

About the Volver and Cerrar or better "Salir" I think is more accurate, I agree with u, but the others ones, not really. I'm from Spain as most of other members of my RP server. And I have not heard "Ganga" referring to a Gang in my entire life. I'm heard "gangs" as a word to say bargain. So I'll change the Volver but no the other one.

@IDKFORCE
Copy link

i understand you have a spain community but you also gotta understand the spanish has to be as central as posible like

 ['manage'] = 'Gestionar empleados',

to

['manage'] = 'Manejar empleados',

or

 ['amount'] = 'Monto',

to

 ['amount'] = 'Cantidad',
['manage'] = 'Manejar miembros de la banda',

to

 ['manage'] = 'Manejar miembros de la pandilla',

@Cocodrulo
Copy link
Author

Although I'm always open to suggestions, I'm afraid based on the translations of other scripts and my/others experience, I think the Spanish I used is very central. So I think I'm going to keep those translation.

Note: I'm going to change "Monto" since it's not very central as you correctly pointed out.

@IDKFORCE
Copy link

respectfully you should go back to school with the dialog you are giving me!

@Cocodrulo
Copy link
Author

I think that's not the actitude. If I think you are not correct, I'll tell you, I'm not telling you that you are completely wrong, only that that is not the Spanish I know from my experience of being from a part of Spain and from my other friends that are from other parts of Spain.

This language is rich and with lots of different words to say same things. But ones are more used than others, and those are the ones that I try to use.

No need to say those things btw.

@Qwerty1Verified
Copy link

I think it's best to have the most diverse language, that being the one that has more people behind it.

@Cocodrulo
Copy link
Author

I put the one I think is more used, at least the one I here more in TV, oficial speeches from Spain institutions, etc

@Cocodrulo
Copy link
Author

Is this going to me merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants