chore: add support for non-imported TS index access (atlassian#32)

qburst-aparna · Nov 29, 2018 · ba9a419 · ba9a419
1 parent 08a2a31
commit ba9a419
Show file tree

Hide file tree

Showing 3 changed files with 64 additions and 7 deletions.
diff --git a/__snapshots__/test.js.snap b/__snapshots__/test.js.snap
@@ -4093,19 +4093,61 @@ Object {
 }
 `;
 
-exports[`typescript indexed type 1`] = `
+exports[`typescript indexed imported type 1`] = `
 Object {
   "classes": Array [
     Object {
-      "kind": "generic",
+      "kind": "object",
+      "members": Array [
+        Object {
+          "key": Object {
+            "kind": "id",
+            "name": "foo",
+          },
+          "kind": "property",
+          "optional": false,
+          "value": Object {
+            "kind": "generic",
+            "value": Object {
+              "kind": "id",
+              "name": "ImportedType['props']",
+            },
+          },
+        },
+      ],
       "name": Object {
         "kind": "id",
         "name": "Component",
         "type": null,
       },
-      "value": Object {
-        "kind": "object",
-        "name": "MyType['props']",
+    },
+  ],
+  "kind": "program",
+}
+`;
+
+exports[`typescript indexed type 1`] = `
+Object {
+  "classes": Array [
+    Object {
+      "kind": "object",
+      "members": Array [
+        Object {
+          "key": Object {
+            "kind": "id",
+            "name": "foo",
+          },
+          "kind": "property",
+          "optional": false,
+          "value": Object {
+            "kind": "number",
+          },
+        },
+      ],
+      "name": Object {
+        "kind": "id",
+        "name": "Component",
+        "type": null,
       },
     },
   ],

diff --git a/index.js b/index.js
@@ -831,6 +831,14 @@ converters.TSIndexedAccessType = (path, context) => {
   const indexKey = path.get('indexType').node.literal.value;
 
   if (type.kind === 'generic') {
+    if (type.value.members) {
+      const member = type.value.members.find((member) =>
+        member.key.name === indexKey
+      );
+      if (member) {
+        return member.value;
+      }
+    }
     return {
       kind: 'generic',
       value: {

diff --git a/test.js b/test.js
@@ -1114,10 +1114,17 @@ const TESTS = [
     typeSystem: 'typescript',
     code: `
       type MyType = {
-        props: RecursiveType
+        props: number;
       }
 
-      class Component extends React.Component<MyType['props']> {}
+      class Component extends React.Component<{ foo: MyType['props'] }> {}
+    `
+  },
+  {
+    name: 'typescript indexed imported type',
+    typeSystem: 'typescript',
+    code: `
+      class Component extends React.Component<{ foo: ImportedType['props'] }> {}
     `
   },
 ];