Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated and migrated packages #55

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

victoralvelais
Copy link
Contributor

Resolves #54

Notes

  • Added a dev dependency as postinstall to fix the Semantic UI import. When using version 5 of react-scripts, an extra semi-colon is added that breaks the import. See this issue for more.

  • Overrides nth-check version to remove vulnerability messages that will not be fixed by the CRA team at this time. See this issue for more.

Also, I see now that the devDependencies property got moved down. I think it was removed during one of the install commands, then re-added when I installed the Semantic UI dependency.

Copy link
Member

@jpdillingham jpdillingham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jpdillingham jpdillingham merged commit 109e364 into qccoders:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tooling
2 participants