#19 Adding emtpy Label and WaitIcon to project folder to make it cons… #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istent to other classes.
|
tests are failing on php < 7. Because qcubed/cache composer.json says requires php7. |
|
I don't think we should requre PHP7. Is there are reason to? PHP 5.6 will probably live for some time, so unless we actually rely on PHP7, why would we require it? |
|
Because it takes effort to maintain it. And 7.1 and 7.2 are already
installed on many servers.
That said, I don't mind supporting 5.6. But then we should probably
- change composer.json to require a minimum of 5.6, not 7.
and
- fix our tests to exclude anything below 5.6
Right?
…On Tue, 13 Nov 2018 at 22:52, Shannon ***@***.***> wrote:
I don't think we should requre PHP7. Is there are reason to? PHP 5.6 will
probably live for some time, so unless we actually rely on PHP7, why would
we require it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADXnE82WZGHtqA6Ymmslt0FKMdeGFaVcks5uuz7_gaJpZM4YcZNW>
.
|
|
I think that is right. But again, if someone wants to do something compelling in QCubed that requires 7, then we switch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19 Adding emtpy Label and WaitIcon to project folder to make it easier and more clear to the developer how he/she should expand the system.