Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#19 Adding emtpy Label and WaitIcon to project folder to make it cons… #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matthiaz
Copy link

#19 Adding emtpy Label and WaitIcon to project folder to make it easier and more clear to the developer how he/she should expand the system.

@matthiaz
Copy link
Author

tests are failing on php < 7. Because qcubed/cache composer.json says requires php7.
So... running a test on php5 probably doesn't make sense. Can we disable those tests?

@spekary
Copy link
Member

spekary commented Nov 13, 2018

I don't think we should requre PHP7. Is there are reason to? PHP 5.6 will probably live for some time, so unless we actually rely on PHP7, why would we require it?

@matthiaz
Copy link
Author

matthiaz commented Nov 13, 2018 via email

@spekary
Copy link
Member

spekary commented Nov 13, 2018

I think that is right. But again, if someone wants to do something compelling in QCubed that requires 7, then we switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants