-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: Added jina embedding v3 #428
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- tests
- license
- users can't change task id in this setting, since we are not propagating kwargs to onnx_embed, they are always hard-coded
Co-authored-by: George <[email protected]>
Co-authored-by: George <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lacks tests of propagation task ids in parallel processing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please upload scripts for canonical vectors computation to the dedicated repo?
|
||
|
||
class JinaEmbeddingV3(PooledNormalizedEmbedding): | ||
DEFAULT_TASK = Task.TEXT_MATCHING |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it might be inconvenient to have a default task different from passage embed task, could we please make it the same?
To compute canonical vectors:
All Submissions:
New Feature Submissions:
pre-commit
withpip3 install pre-commit
and set up hooks withpre-commit install
?New models submission: