-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 1.7.0 #36
Conversation
Also, just to clarify, I already figured why the build fails and how to fix it and currently working on it. (Thanks for the help, @IvanPleshkov! 🙏) |
@ffuugoo my apologies, this needs to be removed in qdrant/qdrant: The namespace should only have been added to qdrant package protos 😵💫 Integrations tests are configured to also run against docker image version specified by
|
TODO: - Remove "internal" imports from `qdrant.proto`
...but I suck at C# and my code doesn't work 😂
@IvanPleshkov suggested to take over and help with C# bits (cause I can't do C#). |
Remove just that single line from the protocol definitions? I can quickly arrange that. Edit: qdrant/qdrant#3180 |
I've added a more "generic" fix for this into this PR (and also created a similar-ish qdrant/qdrant#3181 PR, sorry). |
@timvisee yes, removing that one line will fix compilation. The other issue that will arise is that the integration tests are configured to run against the same docker image label as specified by |
After QDrant @russcam could you please review C# changes meanwhile? We will public client asap after qdrant release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some minor nits and suggestions about keeping timeout
and cancellationToken
parameters as the last parameters.
@IvanPleshkov is doing God's work here. Thanks for picking this up! 😭🙏 |
Co-authored-by: Russ Cam <[email protected]>
Co-authored-by: Russ Cam <[email protected]>
Co-authored-by: Russ Cam <[email protected]>
Co-authored-by: Russ Cam <[email protected]>
Co-authored-by: Russ Cam <[email protected]>
Co-authored-by: Russ Cam <[email protected]>
Co-authored-by: Russ Cam <[email protected]>
Depends on qdrant/qdrant#3175.
WIP