Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse collection fixture #80

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Reuse collection fixture #80

merged 4 commits into from
Jan 16, 2025

Conversation

russcam
Copy link
Collaborator

@russcam russcam commented Jan 15, 2025

(PR is part of a train. Rebase and merge once #78 is merged)

This commit updates the health check test to avoid creating
a separate test fixture, and reuses the collection fixture.
A separate test fixture creates a separate qdrant docker
test container, which is not needed for this test.

This commit updates the health check test to avoid creating
a separate test fixture, and reuses the collection fixture.
A separate test fixture creates a separate qdrant docker
test container, which is not needed for this test.
@russcam russcam requested a review from Anush008 January 15, 2025 23:41
Copy link
Member

@Anush008 Anush008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Russ 🫡

@Anush008 Anush008 merged commit c8ee12e into qdrant:main Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants