Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crc requirement from 1 to 3 #14

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 29, 2022

Updates the requirements on crc to permit the latest version.

Release notes

Sourced from crc's releases.

3.0.0

Bartel Sielski (2):
      Add support for CRC algorithms which have a non-power of 2 width
      Add support for up to 128 bit CRCs

Dominik Stolz (1): Add Crc::digest_with_initial

Cliff L. Biffle (1): impl Clone for Digest

Commits
  • b6dc600 Prepare 3.0.0 release
  • 12c17fb Document behavior of digest_with_initial
  • 60861d8 Apply refin and width to custom initial values
  • 2ef1be5 Add Crc::digest_with_initial
  • 4aeef11 impl Clone for Digest
  • f0e62a3 Remove use of BITS associated const
  • 4a9a15b Add support for up to 128 bit CRCs
  • 384fb68 Add support for CRC algorithms which have a non-power of 2 width
  • f1294c9 Prepare 2.1.0 release
  • 7ace659 Replace Travis CI with GitHub Actions
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 29, 2022

The following labels could not be found: dependencies.

@dependabot dependabot bot force-pushed the dependabot/cargo/crc-3 branch 2 times, most recently from 3697daa to 6f32841 Compare May 2, 2022 12:22
@agourlay
Copy link
Member

agourlay commented May 2, 2022

some info for migrating here mrhooray/crc-rs#62

Updates the requirements on [crc](https://github.com/mrhooray/crc-rs) to permit the latest version.
- [Release notes](https://github.com/mrhooray/crc-rs/releases)
- [Commits](mrhooray/crc-rs@1.0.0...3.0.0)

---
updated-dependencies:
- dependency-name: crc
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@agourlay agourlay requested a review from e-ivkov July 29, 2022 18:41
@agourlay
Copy link
Member

agourlay commented Jul 29, 2022

I finally got something working here by following the discussion mentioned previously.

This part of the code is covered by unit tests which I was able to see failing with a different implementation.

I am not 100% confident TBH but I think it looks fine.

@agourlay agourlay merged commit 72e858a into master Aug 1, 2022
@dependabot dependabot bot deleted the dependabot/cargo/crc-3 branch August 1, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants