wrap UnsafeCell<MmapMut> with a mutex to fix Clippy lint on master #57
Conversation
| @@ -13,7 +14,7 @@ use std::sync::Arc; | |||
| /// The view may be split into disjoint ranges, each of which will share the | |||
| /// underlying memory map. | |||
| pub struct MmapViewSync { | |||
| inner: Arc<UnsafeCell<MmapMut>>, | |||
| inner: Arc<Mutex<UnsafeCell<MmapMut>>>, | |||
There was a problem hiding this comment.
I wonder if we could actually get rid of the UnsafeCell completely now that a Mutex protects from concurrent access?
There was a problem hiding this comment.
I tried to remove UnsafeCell completely, but in fn inner(&self) -> &MmapMut and fn inner_mut(&self) -> &mut MmapMut the compiler says cannot return value referencing temporary value. It seems we still need this UnsafeCell.
I'm a complete rookie for rust, please forgive my ignorance. 😅
|
@ylgrgyq Thanks for giving this a shot! This is a tricky problem. After some consideration I decided to bypass the warning for now (#61). Using a I carefully inspected the code and do think all of it is sound in the current implementation. I do believe that we should improve the architecture of this though to make it a lot harder to misuse. |
According to my understanding, I tried to fix the problem mentioned here #56.
Please have a look and let me known if it is appropriate. Thanks