Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy wal files using memcpy #68

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Conversation

IvanPleshkov
Copy link
Contributor

@IvanPleshkov IvanPleshkov commented Jan 10, 2024

Fix of qdrant/qdrant#2620 on WAL side.

Avoid copy file as fs::copy when mmap is locked by segment. Copying is implemented as new file creation and memcpy over all data. More detailed description why we need such copy you can find here:
#64

@timvisee timvisee changed the title Copy wal fies using memcpy Copy wal files using memcpy Jan 10, 2024
src/segment.rs Outdated Show resolved Hide resolved
@IvanPleshkov IvanPleshkov marked this pull request as draft January 11, 2024 10:33
@IvanPleshkov IvanPleshkov marked this pull request as ready for review January 16, 2024 10:37
src/lib.rs Show resolved Hide resolved
@IvanPleshkov IvanPleshkov merged commit 3f69dff into master Jan 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants