optref, error, bytes, hex #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDimon
reviewed
Nov 8, 2023
xDimon
reviewed
Nov 8, 2023
| #define Q_ERROR_LOCATION \ | ||
| (::qtils::ErrorLocation{__PRETTY_FUNCTION__, __FILE__, __LINE__}) | ||
|
|
||
| #define Q_ERROR(error_) (::qtils::Error{Q_ERROR_LOCATION, error_}) |
There was a problem hiding this comment.
Suggested change
| #define Q_ERROR(error_) (::qtils::Error{Q_ERROR_LOCATION, error_}) | |
| #define Q_ERROR(error_) (::qtils::Error{Q_ERROR_LOCATION, (error_)}) |
There was a problem hiding this comment.
Not an error here (MUL(a,b)a*b; ADD(2+3,4+5); 2+3*4+5)
Harrm
reviewed
Nov 8, 2023
| }; | ||
|
|
||
| /** | ||
| * Used by `OptRef` to reset `T *` on move. |
There was a problem hiding this comment.
Please comment with more details.
Harrm
reviewed
Nov 8, 2023
|
|
||
| namespace qtils { | ||
| /** | ||
| * Used to reset `std::coroutine_handle` on move. |
There was a problem hiding this comment.
Please comment with more details.
Harrm
reviewed
Nov 8, 2023
Comment on lines
+25
to
+26
| const char *fn; | ||
| const char *file; |
There was a problem hiding this comment.
Don't want to increase sizeof(ErrorLocation),
these macro strings are always zero terminated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outcome<T>,Errors,Error,Q_ERROR,Q_TRYoutcome::result<T>,OUTCOME_TRYOptRef<T>Bytes,BytesN<N>,BytesIn,BytesOut"{}" = "0x0102…0506","{:x}" = "010203040506","{:0x}" = "0x010203040506"