-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STAC core part one #58353
STAC core part one #58353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really happy to see this landing in core, thanks for this work!
Local files reading and blocking network requests in QgsStacController
Could we avoid blocking request and use QgsTask ? I can see no way of canceling (I made a very very quick read of this PR though, I made have skipped it), what happen if I want to close the stac catalog window but QGIS is currently retrieving a lot of items?
Blocking requests will only be used for the initial implementation on the browser panel, where |
3ebb704
to
2e41291
Compare
The STAC spec suggests to use In any case, even the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now
(we have discussed the work with Stefanos extensively, so my earlier comments have been addressed already)
If nobody objects, I would merge this tomorrow...
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6builds of this PR for testing. |
This pull request has been tagged for the changelog.
You can edit the description. Format available for credits
Thank you! |
Description
This is the first part of the implementation of qgis/QGIS-Enhancement-Proposals#300
It includes the building block classes for parsing and handling STAC elements and allows interacting with STAC catalogs using the QGIS browser.
The contents of both static catalogs and STAC API endpoints can be retrieved using the new STAC root entry on the browser.
STAC Items that contain assets that are cloud optimized (COG, COPC, EPT for now) can be drag and dropped to the map canvas and those assets will be added as layers.
STAC Item assets may be downloaded to a local folder using the Download Assets dialog.
All Catalogs, Collections and Items properties can be examined using the STAC Object Details dialog:
In subsequent PRs the Data Source Manager implementation will be added which will also allow searching for Items and Collections
Any feedback is warmly welcome!