Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI] Fix project's Ellipsoid option description (adding angle to distance and area) #58660

Merged
merged 2 commits into from
Sep 12, 2024
Merged

[GUI] Fix project's Ellipsoid option description (adding angle to distance and area) #58660

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54633a3
[GUI] Fix project's Ellipsoid option description
agiudiceandrea Sep 11, 2024
99490b7
[GUI] Use a tooltip for project's Ellipsoid option description
agiudiceandrea Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ui/qgsprojectpropertiesbase.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@
<widget class="QLabel" name="textLabel1_8">
<property name="text">
<string>Ellipsoid
(for distance and area calculations)</string>
(distance, area, angle calculations)</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(distance, area, angle calculations)</string>
(distance, area and angle calculations)</string>

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried not to make the text any longer.
Original:
image
My PR
image
Suggested change:
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the text in parenthesis and let's go for a tooltip?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think?
image
(The tooltip is only on the label, not on the combobox)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR updated.

</property>
</widget>
</item>
Expand Down
Loading