added Page Properties qAction to layout main menu

[phidrho]

Description

Adds a menu option to open Page Properties in main Layout menu (see image).

This was available only on right mouse click above empty paper - considered hidden by many users.

Fixes #26237

Fixes #27843 (already closed but this really fixes it)

See #27698 (solves first problem in a list - second is discussable (feature request), and third problem still exists - see bottom of this description)

It's kind of a improvement for #29033

See #35580 (solves point 2, according to @gioman we can also close this one, but I agree that we should entirely remove "Printer Page Setup..." option since it does nothing, whatever you set up there gets ignored and overridden by settings set up in "Page Properties", but this should be done by someone more experienced to left no traces behind.:

If we remove this "Printer Page Setup..." we could also close other bug reports noted above.

This is my first contribution, greetings from Bratislava contributor meeting, special thanks to @uclaros for helping me.

[nicogodet]

Only properties of the first page is accessible with this PR, am I right ?
Properties of pages 2 and + are still only accessible through right click menu.
Is there a way to improve this ?
Either specify this is true for the first page only or opening properties for the page currently in view ?

[nicogodet]

Remove ?

[phidrho]

this was added automatically by Qt Creator, didn't want to touch it.

[github-actions]

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 88bf5a5)

[phidrho]

Only properties of the first page is accessible with this PR, am I right ? Properties of pages 2 and + are still only accessible through right click menu. Is there a way to improve this ? Either specify this is true for the first page only or opening properties for the page currently in view ?

Yes, it always opens properties for first page (at index 0), we could possibly add an additional dialog to choose what page does the user want, but I don't know if it makes much sense. After opening "Page Properties" tab, you can click on any page you want with left mouse click and switch to it, no need for Right click > Menu > Page Properties.

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[nyalldawson]

@phidrho I've added a follow up at #58938, making this respect the current visible page

[qgis-bot]

@phidrho
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

[qgis-bot]

@phidrho

This pull request has been tagged for the changelog.

• The description will be harvested so please provide a "nearly-ready" text for the final changelog
• If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
• If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits

• Funded by NAME
• Funded by URL
• Funded by NAME URL
• Sponsored by NAME
• Sponsored by URL
• Sponsored by NAME URL

Thank you!

[qgis-bot]

@phidrho
A documentation ticket has been opened at qgis/QGIS-Documentation#9288
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

[phidrho]

@phidrho I've added a follow up at #58938, making this respect the current visible page

@nyalldawson really cool, thanks for adding that

I wanted to check on the comment from @nicogodet about additional line in UI file that seems redundant but didn't manage test removing it due to my obligations lately.

I think that removing menu item Printer Page Setup (or at least disabling it, if that's possible) is also needed to properly address all bug reports I noted above. But if you consider it not mandatory then I'm fine with it.

[nyalldawson]

@phidrho

I wanted to check on the comment from @nicogodet about additional line in UI file that seems redundant but didn't manage test removing it due to my obligations lately.

Don't worry about it -- qtcreator randomly adds those, they don't hurt.

I think that removing menu item Printer Page Setup (or at least disabling it, if that's possible) is also needed to properly address all bug reports I noted above. But if you consider it not mandatory then I'm fine with it.

Printer setup does still do something different, but it specifically only has an impact when directly printing a layout.