Fixes #35767 to allow for view creation into specified schema from [ Create a view ] in DBManager #58976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ema from [ Create a view ] in DBManager
nyalldawson
reviewed
Oct 7, 2024
Comment on lines
1017
to
1023
| user_input = view | ||
|
|
||
| if '.' in user_input: # To allow view creation into specified schema | ||
| schema, view_name = user_input.split('.') | ||
| sql = "CREATE VIEW %s AS %s" % (self.quoteId([schema, view_name]), query) | ||
| else: # No schema specified; uses public | ||
| sql = "CREATE VIEW %s AS %s" % (self.quoteId(view), query) |
There was a problem hiding this comment.
This should probably be hardened a little -- eg if the view name was entered badly with two periods, then we'll get a raw python exception here. How about:
Suggested change
| user_input = view | |
| if '.' in user_input: # To allow view creation into specified schema | |
| schema, view_name = user_input.split('.') | |
| sql = "CREATE VIEW %s AS %s" % (self.quoteId([schema, view_name]), query) | |
| else: # No schema specified; uses public | |
| sql = "CREATE VIEW %s AS %s" % (self.quoteId(view), query) | |
| view_name_parts = view.split('.') | |
| if len(view_name_parts) == 2: # To allow view creation into specified schema | |
| schema, view_name = view_name_parts | |
| sql = "CREATE VIEW %s AS %s" % (self.quoteId([schema, view_name]), query) | |
| else: # No specific schema specified | |
| sql = "CREATE VIEW %s AS %s" % (self.quoteId(view), query) |
I've updated the code as recommended and added an error message should there there be too many periods. Thanks for the suggestion!
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nyalldawson
reviewed
Oct 17, 2024
Thanks! Much more user-friendly. Co-authored-by: Nyall Dawson <[email protected]>
nyalldawson
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35767 to allow for view creation into specified schema from [ Create a view ] in DBManager
Description
Currently, using [ Create a view ] from DBManager for postgres automatically loads the view into the public schema named the entire string. It is reasonable for the user to assume that specifying the schema name as schema.view will create the view into the schema specified. Instead, it's creates a view called schema.view in the public schema. This is generally warned against.
Tested
In order to meet users' expectations, allowed for testing if the string has a "." in the name and to separate the string into two parts to feed into the quoteId which is already set up to accept schema and viewname as a list to process appropriately.
Recommended documentation:
"The Create a View button opens a dialog where you can enter the name for the new view. By default, the view is created in the public schema of the PostgreSQL database. However, you can specify a different schema by using the schema.viewname naming convention."
Backporting is recommended to meet user expectations.
Fixes #35767 to allow for view creation into specified schema from [ Create a view ] in DBManager