Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport queued ltr][network] Implement a smart cache size #58981

Closed
wants to merge 2 commits into from

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Oct 6, 2024

Description

Manual backport of #58548 -- the idea here is to backport onto LTR as many changes as we deem acceptable to insure we are a good citizen towards OSMF and their tiling service.

@nirvn nirvn added the Backport Is a backport of another pull request label Oct 6, 2024
@github-actions github-actions bot added this to the 3.40.0 milestone Oct 6, 2024
@nirvn nirvn changed the title [network] Implement a smart cache size [backport queued ltr][network] Implement a smart cache size Oct 6, 2024
Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me nervous. I understand the motivation in being a good player with osm, but it's very invasive changes to be introduced at this stage in the ltr lifespan. Not to mention that it potentially affects corporate rollouts which rely on the existing cache size settings key...

@nirvn
Copy link
Contributor Author

nirvn commented Oct 10, 2024

@nyalldawson , that's a reasonable argument. I wanted us to be able to take a deliberate decision on this.

If there are no diverging opinions, I'll merge this by end of week.

@Gustry
Copy link
Contributor

Gustry commented Oct 11, 2024

Not to mention that it potentially affects corporate rollouts which rely on the existing cache size settings key...

I agree. For system administrator (not GIS technicians) migrating from a previous LTR 3.Y to a new LTR 3.X, there isn't such info about settings keys changed. I'm not talking about this specific setting key but more a broad status about changed settings key. I would be happy to help, but it's difficult to track such change in the settings file .ini. Recently, we encountered the changed setting networkAndProxy\networkTimeout which has changed between 3.28 and 3.34, which changed the QGIS Server behavior.

For QGIS Server deployment, this PR will break the cache if it's set with the .ini file but not if it's using the environment variable if I'm not wrong. The INI file is necessary for QGIS server deployment, because there are many settings not available using environment variable. So for a system administrator, I wouldn't expect a setting changed in the INI file between two bugfix versions of 3.34.

Sorry if I'm wrong, I didn't follow the new settings migration :)

@nirvn nirvn closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Is a backport of another pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants