[backport queued ltr][processing] Insure that processing algorithms are not used to breach the OSMF tile usage policy on bulk download #58982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are not used to conduct bulk download of OSM tiles
…sed to conduct bulk download OSM tiles
…en exporting the layer to file (both via the browser panel as well as the layer tree)
nyalldawson
reviewed
Oct 7, 2024
| if ( totalTiles > MAXIMUM_OPENSTREETMAP_TILES_FETCH ) | ||
| { | ||
| // Prevent bulk downloading of tiles from openstreetmap.org as per OSMF tile usage policy | ||
| feedback->pushWarning( QObject::tr( "Layer %1 will be skipped as the algorithm leads to bulk downloading behavior which is prohibited by the %2OpenStreetMap Foundation tile usage policy%3" ).arg( rasterLayer->name(), QString(), QString() ) ); |
There was a problem hiding this comment.
I don't understand the empty arguments used here?
There was a problem hiding this comment.
@nyalldawson , ah, that's because I was trying to avoid creating a new translation string. On master, you can see how the same string is used both with and without HTML formatting when used with pushFormattedMessage: https://github.com/qgis/QGIS/blob/master/src/analysis/processing/qgsalgorithmrasterize.cpp#L203-L204
That function isn't available in 3.34, yet I was thinking it;d be better to stick to the same untranslated string.
| if ( QgsMapLayerUtils::isOpenStreetMapLayer( layer ) ) | ||
| { | ||
| // Prevent bulk downloading of tiles from openstreetmap.org as per OSMF tile usage policy | ||
| feedback->pushWarning( QObject::tr( "Layer %1 will be skipped as the algorithm leads to bulk downloading behavior which is prohibited by the %2OpenStreetMap Foundation tile usage policy%3" ).arg( layer->name(), QString(), QString() ) ); |
There was a problem hiding this comment.
Same here -- why the empty static arguments?
nyalldawson
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of #58550 and #58584 -- the idea here is to backport onto LTR as many changes as we deem acceptable to insure we are a good citizen towards OSMF and their tiling service.