[fix] Make scale dependent visibility more robust for labels #59022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity: handle exclusive/inclusive behavior on edge cases (non-round numbers)
gacarrillor
added
Labeling
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nyalldawson
reviewed
Oct 9, 2024
nirvn
reviewed
Oct 9, 2024
…o indicate that min scale is exclusive and max scale is inclusive
gacarrillor
force-pushed
the
scale_dependent_robustness_non_round_scales_labeling
branch
from
b7c975e
to
474dab8
Compare
nyalldawson
approved these changes
Oct 9, 2024
gacarrillor
deleted the
scale_dependent_robustness_non_round_scales_labeling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup #58968
Make labeling more robust when handling scale dependent visibility: handle exclusive/inclusive behavior on edge cases (non-round numbers).
Also, add tooltip for scale dependent visibility widgets (labeling) to indicate that min scale is exclusive and max scale is inclusive.
Fix #42443