Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queued LTR backports #59225

Merged
merged 72 commits into from
Oct 25, 2024
Merged

Queued LTR backports #59225

merged 72 commits into from
Oct 25, 2024

Commits on Oct 25, 2024

  1. Configuration menu
    Copy the full SHA
    4e43c17 View commit details
    Browse the repository at this point in the history
  2. [layouts] Fix computation of atlas rectangle for rotated map items wh…

    …en no atlas geometry available
    nirvn authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a633e44 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c74c4b7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    25aade1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    274b0e0 View commit details
    Browse the repository at this point in the history
  6. fix layout

    3nids authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    39e0bf6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4eaadc2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    19500e1 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    cc62ecc View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b9140dc View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e7c9fc8 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    100d5e1 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ca71516 View commit details
    Browse the repository at this point in the history
  14. Save Raster Layer as: do not propose PDF as possible format, which is…

    … not supported
    
    The PDF driver only supports 'random' creation for vectors, not raster.
    For raster, it only supports CreateCopy() mode
    
    Refs #58891
    rouault authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    4955936 View commit details
    Browse the repository at this point in the history
  15. Don't show font size preview in font button icons

    Just reset the font size to a standard size when generating the
    preview, otherwise we end up with invisible text on the buttons
    if the font size is too big or too little.
    nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    982b757 View commit details
    Browse the repository at this point in the history
  16. fix(LayoutLegend): Correctly fix position while painting

    While painting, it happens that other code can modify current item
    position, but this new position will be really used on the new draw,
    not the current one. So we have to backup it early enough (at the very
    beginning of paint) so we can translate to this new position at the
    end of the paint method.
    
    Fixes #37566 (Again)
    troopa81 authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    483c561 View commit details
    Browse the repository at this point in the history
  17. Fix AttributeError: module 'plotly.graph_objs' has no attribute 'Area…

    …': it is go.Barplot in recent plotly versions
    florianneukirchen authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d6a075f View commit details
    Browse the repository at this point in the history
  18. value field must be numeric

    florianneukirchen authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    b588133 View commit details
    Browse the repository at this point in the history
  19. Fix indentation

    florianneukirchen authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    985b69e View commit details
    Browse the repository at this point in the history
  20. Fix issue whereby toggling the 'Move selected to top' action in the a…

    …ttribute table dialog
    
    breaks the current sort column and sort order due to the column and order being
    hard-coded to 0 and Qt::AscendingOrder respectively.
    benwirf authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5db4443 View commit details
    Browse the repository at this point in the history
  21. Update unit tests

    benwirf authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    b80bc6f View commit details
    Browse the repository at this point in the history
  22. Fix build

    nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f8b21ae View commit details
    Browse the repository at this point in the history
  23. [digitizing] Advanced: fix distance input with non-meter CRSs

    Always internally store the distance in canvas's CRS units,
    transform for display.
    
    Fix #58620 where the CRS units are US Feet.
    elpaso authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    83cd0a5 View commit details
    Browse the repository at this point in the history
  24. Fix build

    nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    e9863f1 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    ca9439c View commit details
    Browse the repository at this point in the history
  26. preview residuals while moving points

    uclaros authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d8a928f View commit details
    Browse the repository at this point in the history
  27. tidy up includes

    uclaros authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    98bf3e9 View commit details
    Browse the repository at this point in the history
  28. clang-tidy

    uclaros authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    077be22 View commit details
    Browse the repository at this point in the history
  29. [labeling] Fix SLD export of negative offset

    Fix #58862
    elpaso authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    256c778 View commit details
    Browse the repository at this point in the history
  30. [mssql] Fix nvarchar length #58809

    elpaso authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    722bb98 View commit details
    Browse the repository at this point in the history
  31. Add QMetaType import

    elpaso authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    1f537b5 View commit details
    Browse the repository at this point in the history
  32. Only use threaded legend hit test for preview renders

    In other cases we'll need a blocking hit test anyway, and we
    run a risk of deadlocks if a non-preview render is then started
    on the main thread.
    
    Fixes #58496
    nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    09e0b7e View commit details
    Browse the repository at this point in the history
  33. qgswfsgetfeature: Fix outputCrs in startGetFeature if defined as ogc urn

    The `srsName` used in `QgsWfsGetFeature::startGetFeature` can be
    defined with the `urn:ogc:def:crs:EPSG::X` syntax. In that case, the
    destination crs is not valid because it is created with the default
    `QgsCoordinateReferenceSystem` constructor which does not handle this
    syntax.
    Therefore, in that case, the requested transformation fails and the
    envelope coordinates are always in the input crs (the layer one).
    
    This issue is fixed by using
    `QgsCoordinateReferenceSystem::setDestinationCrs` which handles the
    ogc urn syntax.
    
    The test suite already covers the `urn:ogc:def:crs:EPSG::X` syntax
    case. However, this issue is not detected because the requested output
    crs is the same as the input one.
    ptitjano authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a49929f View commit details
    Browse the repository at this point in the history
  34. qgswfsgetfeature: Properly check axis inversion in startGetFeature

    The axis inversion needs to be checked on the output crs, not the
    input one.
    
    The existing test does not detect this issue because the requested
    output crs is the same as the input one.
    To cover this case, a new test with a output crs different from the
    input one is added.
    ptitjano authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    b697aab View commit details
    Browse the repository at this point in the history
  35. qgswfsgetfeature: Rename srsName to ouptutSrsName in startGetFeature

    This makes it easier to understand its usage.
    ptitjano authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    eab3e12 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    5fb1667 View commit details
    Browse the repository at this point in the history
  37. qgswfsgetfeature: Properly handle ogc urns in post requests

    There are 2 different parameters to check to define the output crs:
    - the request parameter (`SRSNAME` from the request)
    - the query crs parameter
    
    For a `GET` request, if `SRSNAME` is set, both parameters are set and
    equal.
    For a `POST` request, only the query parameter is set if defined.
    
    In `writeGetFeature()`, the `outputCrs` correctly takes into account
    the query parameter. However, this is not the case for the output srs
    name (`srsName`) which only takes into account the query CRS as an
    auth id.
    Therefore, the output srsName will always be defined as an authid
    even if the parameter is an ogc urn.
    
    This issue is fixed by first computing the output srs
    name (`outputSrsName`) by taking
    into account the query and the query parameters. Then, this name is
    used to compute `outputCrs`.
    ptitjano authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2e322f2 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    8d9026d View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    985b986 View commit details
    Browse the repository at this point in the history
  40. Fix missing canvas variables in some expression editors

    Always use the canvas method to create an expression context
    for expression widgets (when available), as it will always
    contain all the available variables.
    
    Fixes missing variables (eg @animation_*) in some contexts,
    eg in the labeling widget.
    nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    346bde7 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    0d7b887 View commit details
    Browse the repository at this point in the history
  42. Avoid useless loop through all features

    When a layout attribute table is set to show features in atlas
    only, but atlas geometry is NOT available, then just early
    exit instead of looping through every feature just to show
    none of them
    nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    c9a01ea View commit details
    Browse the repository at this point in the history
  43. Fix layout table filtering with atlas point geom filter

    The filter rect was NOT being set in this situation, because
    the atlas geom filter has an empty (but non-null) extent
    
    Fixes #58274
    nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    8a2d39d View commit details
    Browse the repository at this point in the history
  44. Update test

    nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    52c77dd View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    2944363 View commit details
    Browse the repository at this point in the history
  46. [processing] Add tile creation counts to the create XYZ directory/mbt…

    …iles algorithms
    nirvn authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    963f5b5 View commit details
    Browse the repository at this point in the history
  47. [processing] Insure that the create XYZ directory/mbtiles algorithms …

    …are not used to conduct bulk download of OSM tiles
    nirvn authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5b38ec2 View commit details
    Browse the repository at this point in the history
  48. [processing] Insure that the convert map to raster algorithm is not u…

    …sed to conduct bulk download OSM tiles
    nirvn authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2bda3f3 View commit details
    Browse the repository at this point in the history
  49. Address review

    nirvn authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    dd6008a View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    cd5d344 View commit details
    Browse the repository at this point in the history
  51. [browsers] Prevent users from breaching the OSMF tile usage policy wh…

    …en exporting
    
    the layer to file (both via the browser panel as well as the layer tree)
    nirvn authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    3e6395c View commit details
    Browse the repository at this point in the history
  52. Address review

    nirvn authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f552dfa View commit details
    Browse the repository at this point in the history
  53. Fix compilation against 3.34

    nirvn authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f3e148f View commit details
    Browse the repository at this point in the history
  54. Non-default blend mode should force raster render of layer

    Fixes rendering of vector tile and annotation layers with non
    default blend modes in layouts
    
    Fixes #55629
    
    (cherry picked from commit 9ed009f)
    nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    e1a5893 View commit details
    Browse the repository at this point in the history
  55. Fix build

    nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    fa8767c View commit details
    Browse the repository at this point in the history
  56. fix(SvgSelectorWidget): Correctly use QPixmapCache

    With previous code, pixmap was never taken from cache
    troopa81 authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5aa2aaa View commit details
    Browse the repository at this point in the history
  57. [ogr][transactions] Fix transaction group

    Fix #58845
    elpaso authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    21fb99b View commit details
    Browse the repository at this point in the history
  58. fix(AttributeForm): Update same field widgets before firing signals

    If not, saveEdits would be called when we fire widgetValueChanged
    signal and widgets containing non updated old values could potentially
    overwrite new ones, leading to discard user modifications.
    troopa81 authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    907fa62 View commit details
    Browse the repository at this point in the history
  59. explicitly force std::as_const

    Co-authored-by: Alessandro Pasotti <[email protected]>
    2 people authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    625bcbb View commit details
    Browse the repository at this point in the history
  60. Fix aggregate function returns incorrect results

    When the aggregate uses variables, we need to ensure that the
    cache key correctly considers the current value of ALL those
    variables. Otherwise we'll return incorrect results when
    an expression is re-evaluated after changing the variable
    value for the context.
    
    Fixes use of aggregate function with @symbol_label in legends.
    
    Fixes #58221
    
    (cherry picked from commit 7b88103)
    nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f7503df View commit details
    Browse the repository at this point in the history
  61. Include variable name in result

    (cherry picked from commit f618993)
    nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    630b7d8 View commit details
    Browse the repository at this point in the history
  62. Sipify

    nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    4f7e6f5 View commit details
    Browse the repository at this point in the history
  63. QgsRasterLayer: readXml(): read layer notes even when opening with Fl…

    …agDontResolveLayers
    
    Fixes #58818
    
    (cherry picked from commit 0c9320c)
    rouault authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    25a229c View commit details
    Browse the repository at this point in the history
  64. Configuration menu
    Copy the full SHA
    0d10556 View commit details
    Browse the repository at this point in the history
  65. Don't restore corrupted sizes/positions when restoring layout items

    This can happen when eg a broken item size causes a nan position,
    which breaks the layout size calculation and results in nan or
    massive x/y values. Restoring these leads to a broken
    layout which cannot be interacted with.
    
    Refs #55240
    nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    0627961 View commit details
    Browse the repository at this point in the history
  66. Configuration menu
    Copy the full SHA
    96c7320 View commit details
    Browse the repository at this point in the history
  67. Configuration menu
    Copy the full SHA
    9a86888 View commit details
    Browse the repository at this point in the history
  68. Don't try to resize layout map items when extent is invalid

    This causes the map item to have nan pos or size, which corrupts
    the layout
    nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a3d0635 View commit details
    Browse the repository at this point in the history
  69. Configuration menu
    Copy the full SHA
    1e48dcf View commit details
    Browse the repository at this point in the history
  70. fix(ValueRelation): Update on widget value change when multi mode

    In multi edit mode feature is not updated (so attributeChanged is false) until user validate it but we need to update the
    value relation which could have an expression depending on another modified field
    troopa81 authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f341fd1 View commit details
    Browse the repository at this point in the history
  71. Configuration menu
    Copy the full SHA
    45751f4 View commit details
    Browse the repository at this point in the history
  72. Delete equality operator of QgsMapLayerRef and make its bool operator…

    … explicit
    
    This will avoid implicit conversion to bool when comparing QList<QgsMapLayerRef>s in the future.
    uclaros authored and nyalldawson committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    66a909d View commit details
    Browse the repository at this point in the history