fix(layertreeview): add checks on selectedModel to avoid segfault #59337
Conversation
Fixes qgis#59329 QGIS crashes when executing this line (and other from the same family) in the Python console: QgsLayerTreeView().selectedLayers()
Djedouas
added
backport queued_ltr_backports
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
PyQgsLayerTreeView crashes on QT6 https://github.com/qgis/QGIS/actions/runs/11690407551/job/32556700307?pr=59337 |
|
@nyalldawson @rouault do you have an idea why the Qt6 test has a segfault? I can run the test in both Qt5 and Qt6 on my machine and it is fine... Is seems as if the Qt6 test uses the code without my modifications... |
did you try running under Valgrind, just in case this might be something subtle... Or maybe it is due to a difference of Qt6 versions between your machine and the CI one ? |
|
@Djedouas looks like the test is actually hanging and timing out and being forcefully closed. But I can't see anything here that would lead to a hang... 🤔 I'd check if it's the new test causing this (as opposed to an existing test impacted by these changes) by temporarily removing it... |
Description
Fixes #59329
QGIS crashes when executing this line (and other from the same family) in the Python console: