Test0303 #5
Test0303 #5
Conversation
Co-authored-by: Flowyi <[email protected]>
Co-authored-by: wlwilliamx <[email protected]>
Co-authored-by: wlwilliamx <[email protected]>
…ocs-cn into ldz/add-ticdc-new-arch
Co-authored-by: Flowyi <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
…ocs-cn into ldz/add-ticdc-new-arch
|
Warning Rate limit exceeded@qiancai has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 37 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThis pull request updates the project documentation and configuration related to the new TiCDC architecture. It adds two new documentation files describing the architecture and monitoring metrics, updates the table of contents to include these entries, and introduces a new configuration parameter ( Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant GH as GitHub Actions
participant CR as AI Code Reviewer
Dev->>GH: Open Pull Request
GH->>GH: Trigger "code_review.yml" workflow
GH->>GH: Checkout repository (actions/checkout)
GH->>CR: Invoke AI Code Reviewer action
CR-->>GH: Return review feedback
GH-->>Dev: Post review comments
sequenceDiagram
participant TiDB as Upstream TiDB
participant LS as Log Service
participant DA as Downstream Adapter
TiDB->>LS: Push real-time data changes
LS->>DA: Provide stored change data
DA->>LS: Request additional data as needed
DA-->>Changefeed: Process and sync changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
ticdc/ticdc-new-arch.md (1)
114-114: Markdown Lint Style Suggestion:
Markdownlint has flagged an ordered list item prefix (line 114) that uses "3." instead of the recommended "1." for new lists. To improve maintainability and readability, consider normalizing all ordered list prefixes to "1."🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
114-114: Ordered list item prefix
Expected: 1; Actual: 3; Style: 1/2/3(MD029, ol-prefix)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
media/ticdc/ticdc-new-arch-1.jpgis excluded by!**/*.jpgmedia/ticdc/ticdc-new-arch-2.jpgis excluded by!**/*.jpg
📒 Files selected for processing (8)
TOC.md(1 hunks)faq/migration-tidb-faq.md(1 hunks)optimizer-fix-controls.md(1 hunks)production-deployment-using-tiup.md(4 hunks)releases/release-8.4.0.md(1 hunks)ticdc/ticdc-new-arch-monitor.md(1 hunks)ticdc/ticdc-new-arch.md(1 hunks)ticdc/ticdc-server-config.md(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- ticdc/ticdc-new-arch-monitor.md
- releases/release-8.4.0.md
- faq/migration-tidb-faq.md
- production-deployment-using-tiup.md
- optimizer-fix-controls.md
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
ticdc/ticdc-new-arch.md
114-114: Ordered list item prefix
Expected: 1; Actual: 3; Style: 1/2/3
(MD029, ol-prefix)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: pull
🔇 Additional comments (16)
ticdc/ticdc-server-config.md (1)
33-38: New Configuration Parameter Documentation:
The addition of thenewarchparameter is well-documented. The section clearly explains its purpose (to control the new TiCDC architecture), the version from which it’s introduced, its default behavior, and the caveat regarding its usage in the old architecture configuration.TOC.md (1)
181-186: TOC Enhancements for TiCDC New Architecture:
The two new entries—“TiCDC 新架构介绍” and “TiCDC 新架构监控指标”—integrate well into the documentation hierarchy. Ensure that the link for the monitoring metrics page is updated when the placeholder content is replaced.ticdc/ticdc-new-arch.md (14)
1-5: Document Header and Front Matter:
The front matter section (lines 1–5) is clear and properly formatted. The title and summary provide a concise introduction to the document’s purpose.
6-16: Overview Section:
The "概述" section effectively highlights the main advantages of the new architecture. The bullet points are concise and communicate the benefits well.
17-25: Architectural Design:
The description of the core components (Log Service and Downstream Adapter) is detailed and well-structured. The inclusion of images to illustrate concepts is a great touch—please verify that the referenced image URLs are accessible in all deployment contexts.
26-27: Component Separation Explanation:
The brief discussion contrasting the stateful (Log Service) and stateless (Downstream Adapter) parts is clear and informative. This helps users understand the design choices made for scalability and resource efficiency.
28-43: New vs. Old Architecture Comparison:
The comparative table clearly outlines the improvements made with the new architecture across various dimensions such as task triggering, scheduling, efficiency, resource consumption, and scalability. This table is a valuable addition for users to understand the impact of the redesign.
46-64: Deployment Guide Section:
The deployment instructions are comprehensive. The TiUP configuration snippet (lines 54–62) is especially helpful in illustrating how to enable the new architecture using thenewarchparameter.
68-73: Deploying the New Architecture in an Existing Cluster:
The step-by-step instructions for deploying new TiCDC nodes in an existing cluster are clear. Please double-check that all cross-references (e.g., to "扩容 TiCDC 节点") are correct and up to date.
74-80: TiCDC Upgrade Instructions:
The upgrade steps, including the important note that downgrading isn’t supported after switching to the new architecture, are well presented. The use of a block quote for the warning is effective in drawing attention.
82-97: Downloading and Patching Instructions:
The commands provided for downloading the appropriate TiCDC binary and patching the cluster are clear. Verify that the download URL format remains current with the latest releases.
98-107: Updating TiCDC Configuration:
The instructions for editing the TiCDC configuration via TiUP (including the code snippet showing the addition ofnewarch: true) are straightforward and should help users correctly enable the new architecture.
108-113: Restoring Changefeed Tasks:
The brief reminder to restore the Changefeed tasks after the configuration update ensures that users do not overlook this necessary post-upgrade step.
125-130: Query Command Verification:
The command provided for querying a specific changefeed looks correct and follows expected syntax.
132-133: Additional Documentation Reference:
The suggestion to review the [管理 Changefeed] documentation for more details is useful and directs users to further resources.
134-148: Attention and Experimental Features:
The "注意事项" section effectively communicates the key differences in DDL synchronization between the old and new architectures and lists the experimental features that are not yet fully implemented. This helps set appropriate expectations for users testing or deploying the new system.
| 例如，要在新架构的 TiCDC 节点中创建同步任务，可执行以下命令： | ||
|
|
||
| ``` | ||
| cdc cli changefeed create cdc cli changefeed create --server=http://127.0.0.1:8300 --sink-uri="mysql://root:[email protected]:3306/" --changefeed-id="simple-replication-task" | ||
| ``` |
There was a problem hiding this comment.
Command Syntax Correction:
The command shown for creating a new changefeed appears to have a duplicated invocation—"cdc cli changefeed create" is repeated. This redundancy may cause confusion or command failure. Please remove the duplicate text.
Suggested diff:
- cdc cli changefeed create cdc cli changefeed create --server=http://127.0.0.1:8300 --sink-uri="mysql://root:[email protected]:3306/" --changefeed-id="simple-replication-task"
+ cdc cli changefeed create --server=http://127.0.0.1:8300 --sink-uri="mysql://root:[email protected]:3306/" --changefeed-id="simple-replication-task"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| 例如，要在新架构的 TiCDC 节点中创建同步任务，可执行以下命令： | |
| ``` | |
| cdc cli changefeed create cdc cli changefeed create --server=http://127.0.0.1:8300 --sink-uri="mysql://root:[email protected]:3306/" --changefeed-id="simple-replication-task" | |
| ``` | |
| 例如，要在新架构的 TiCDC 节点中创建同步任务，可执行以下命令： | |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| API_PROVIDER: "deepseek" # or "openai" if you want to use OpenAI | ||
| DEEPSEEK_API_KEY: ${{ secrets.DEEPSEEK_API_KEY }} | ||
| DEEPSEEK_API_MODEL: "deepseek-chat" # Updated model name |
There was a problem hiding this comment.
The model name deepseek-chat seems to be a placeholder or incorrect. Please verify the correct model name to ensure the workflow functions as expected.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/code_review.yml (1)
10-10: Review Permission Scope.
Thepermissions: write-allsetting is very broad. Consider whether your workflow needs full write access or if a more minimal permission (e.g., explicitly listing required scopes) might suffice from a security standpoint.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.github/workflows/code_review.yml(1 hunks)ticdc/ticdc-new-arch.md(1 hunks)tidb-monitoring-api.md(1 hunks)tiproxy/tiproxy-load-balance.md(1 hunks)tiproxy/tiproxy-overview.md(2 hunks)tiproxy/tiproxy-traffic-replay.md(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- tiproxy/tiproxy-load-balance.md
- tiproxy/tiproxy-traffic-replay.md
- tiproxy/tiproxy-overview.md
- tidb-monitoring-api.md
🚧 Files skipped from review as they are similar to previous changes (1)
- ticdc/ticdc-new-arch.md
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/code_review.yml
17-17: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: pull
🔇 Additional comments (3)
.github/workflows/code_review.yml (3)
1-2: Clear Workflow Naming.
The workflow is named AI Code Review, which clearly communicates its purpose.
3-9: Correct Trigger Configuration.
The workflow is set to trigger on pull request events (opened, synchronize, reopened), ensuring that reviews run when PR activity occurs.
19-27: AI Code Reviewer Step Configuration.
The step invoking theqiancai/ai-codereviewer@testaction is correctly configured with the necessary inputs. However, ensure that using thetesttag is intentional; if stability is a concern, consider referencing a stable release tag. Also, double-check that the API provider, model, and secret values are correct and up-to-date.
| - name: Checkout Repo | ||
| uses: actions/checkout@v3 | ||
|
|
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Update Checkout Action Version.
Static analysis indicates that the runner for actions/checkout@v3 might be outdated. Verify if a newer release is available (for example, an updated minor version like actions/[email protected] or similar) and update accordingly to leverage improvements and avoid potential runner issues.
A possible diff if an update is available:
- uses: actions/checkout@v3
+ uses: actions/[email protected]I'll now perform a web search to verify the latest stable version of the actions/checkout GitHub Action. This will help confirm whether updating from actions/checkout@v3 to a more specific version (e.g., actions/[email protected]) is supported or recommended.
🌐 Web query:
What is the latest stable version of the GitHub Action "actions/checkout" available on GitHub as of March 2025?
💡 Result:
The latest stable version of the actions/checkout GitHub Action as of March 2025 is v4.2.2, with ongoing maintenance under the v4 major version tag. This aligns with the most recent release notes from November 2024 in the repository's changelog[9][10], which show incremental updates and fixes for the v4 series.
Key details about the v4 branch:
- Introduced performance improvements and sparse checkout support[3][7]
- Added configuration options for SSH authentication and submodule handling[9]
- Maintained backward compatibility with workflows using earlier
v4.x.xversions[4][9]
For most use cases, specifying uses: actions/checkout@v4 in workflows automatically pulls the latest stable minor/patch version under the v4 umbrella[1][6]. The action remains compatible with GitHub's updated runner environments as of March 2025[4].
Citations:
- 1: https://graphite.dev/guides/github-actions-checkout
- 2: https://o-ifeanyi.hashnode.dev/flutter-fastlane-github-actions-part-2
- 3: https://github.com/actions/checkout
- 4: https://github.blog/changelog/2024-09-25-actions-new-images-and-ubuntu-latest-changes/
- 5: https://github.com/marketplace/actions/checkout
- 6: https://docs.github.com/en/[email protected]/actions/writing-workflows/quickstart
- 7: https://github.com/actions/checkout/blob/main/CHANGELOG.md
- 8: https://ferrous-systems.com/blog/gha-hil-tests/
- 9: https://github.com/actions/checkout/releases
- 10: https://github.com/orgs/community/discussions/110853
Update Checkout Action Version to v4
The current workflow uses actions/checkout@v3, which is now outdated. As of March 2025, the latest stable release of the actions/checkout action is in the v4 series (specifically v4.2.2). This update provides performance improvements, enhanced configuration options, and ongoing maintenance. Please update the workflow to use the v4 major version so that it automatically pulls the latest stable minor and patch releases.
- File:
.github/workflows/code_review.yml(Lines 16-18) - Suggested diff:
- uses: actions/checkout@v3 + uses: actions/checkout@v4
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Checkout Repo | |
| uses: actions/checkout@v3 | |
| - name: Checkout Repo | |
| uses: actions/checkout@v4 |
🧰 Tools
🪛 actionlint (1.7.4)
17-17: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
| - **更高的稳定性**：在高流量、频繁 DDL 操作及集群扩缩容等场景下，Changefeed 的延迟更低且更加稳定。通过资源隔离和优先级调度，减少了多个 Changefeed 任务之间的相互干扰。 | ||
| - **更低的资源成本**：通过改进资源利用率，减少冗余开销，在典型场景下，CPU、内存等资源的利用效率提升最多一个数量级。 | ||
|
|
||
| ## 架构设 |
There was a problem hiding this comment.
The heading ## 架构设 appears to be incomplete. It should be ## 架构设计 to match the intended content and maintain consistency with the document's structure.
|
|
||
| TiCDC 新架构通过将整体架构拆分成有状态和无状态的两部分，显著提升了系统的可扩展性、可靠性和灵活性。Log Service 作为有状态组件，专注于数据的获取、排序和存储，通过与 Changefeed 业务逻辑的解耦，实现了数据在多个 Changefeed 间的共享，有效提高了资源利用率，降低了系统开销。 Downstream Adapter 作为无状态组件，采用轻量级调度机制，支持任务在不同实例间的快速迁移，并根据负载变化灵活调整同步任务的拆分与合并，确保在各种场景下都能实现低延迟的数据同步。 | ||
|
|
||
| ## 新老架对比 |
There was a problem hiding this comment.
The heading ## 新老架对比 seems to have a typo. It should be ## 新老架构对比 to maintain consistency and correctness in the documentation.
| ## 新老架对比 | |
| `## 新老架构对比` to maintain consistency and correctness in the documentation |
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
ticdc/ticdc-new-arch.md (1)
123-124:⚠️ Potential issueDuplicate Command Invocation:
The command snippet repeats “cdc cli changefeed create” twice. This duplication can lead to confusion or execution errors. Please remove the redundant invocation so that the command appears only once.- cdc cli changefeed create cdc cli changefeed create --server=http://127.0.0.1:8300 --sink-uri="mysql://root:[email protected]:3306/" --changefeed-id="simple-replication-task" + cdc cli changefeed create --server=http://127.0.0.1:8300 --sink-uri="mysql://root:[email protected]:3306/" --changefeed-id="simple-replication-task"
🧹 Nitpick comments (4)
ticdc/ticdc-new-arch.md (4)
23-23: Typo in Log Service Description:
The phrase “这是一除示例” likely contains a typo. Consider revising it to “这只是一个示例” (or another clear phrasing) for improved readability.
82-82: Typo in Download Instruction:
The text “TiCDC 二进制文” appears to be truncated. It is recommended to change it to “TiCDC 二进制文件”.-1. 下载 v9.0.0 或者以上版本的 TiCDC 二进制文. +1. 下载 v9.0.0 或者以上版本的 TiCDC 二进制文件.
114-114: Ordered List Numbering Consistency:
The ordered list item on this line is prefixed with “3.” which may conflict with markdownlint’s MD029 (which prefers a consistent numbering style, e.g. using “1.” for all items). Please consider updating the list items to use a uniform prefix.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
114-114: Ordered list item prefix
Expected: 1; Actual: 3; Style: 1/2/3(MD029, ol-prefix)
118-118: Punctuation Consistency:
In the sentence starting on this line, the period after “操作” seems to break the flow. Consider replacing it with a comma to maintain a consistent and smoother reading experience.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ticdc/ticdc-new-arch.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
ticdc/ticdc-new-arch.md
114-114: Ordered list item prefix
Expected: 1; Actual: 3; Style: 1/2/3
(MD029, ol-prefix)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: pull
🔇 Additional comments (1)
ticdc/ticdc-new-arch.md (1)
17-17: Heading Completeness Correction:
The section heading on this line reads “## 架构设”, which appears to be incomplete. Please update it to “## 架构设计” to improve clarity and maintain consistency with similar documentation sections.
|
|
||
| TiCDC 新架构仅支持 v7.5 或者以上版本的 TiDB 集群，使用之前需要确保 TiDB 集群版本满足要求。 | ||
|
|
||
| ### 使用 TiUP 部署启用新架 TiCDC 的全新 TiDB 集群 |
There was a problem hiding this comment.
There is a typo in the heading. It should be 新架构 instead of 新架. Please correct it to maintain consistency and accuracy in the documentation.
| ### 使用 TiUP 部署启用新架 TiCDC 的全新 TiDB 集群 | |
| `新架构` instead of `新架` |
| 更多命令的使用方法和细节，可以参考[管理 Changefeed](/ticdc/ticdc-manage-changefeed.md)。 | ||
| ## 注意事 |
There was a problem hiding this comment.
The section title ## 注意事 appears to be incomplete. It should likely be ## 注意事项 to match the context and maintain consistency with the rest of the documentation.
|
|
||
| 2. 参考下一节启用 TiCDC 新架构。 | ||
|
|
||
| ### 使用 TiUP 将原有 TiDB 集中的 TiCDC 升级为新架 |
There was a problem hiding this comment.
The heading text is incorrect and contains typos. It should be corrected to match the original meaning.
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
ticdc/ticdc-new-arch.md (1)
122-124:⚠️ Potential issueCommand Duplication: Remove redundant command text.
The command in the code snippet appears to be duplicated (“cdc cli changefeed create” is repeated). This redundancy may confuse users.
A suggested diff:-cdc cli changefeed create cdc cli changefeed create --server=http://127.0.0.1:8300 --sink-uri="mysql://root:[email protected]:3306/" --changefeed-id="simple-replication-task" +cdc cli changefeed create --server=http://127.0.0.1:8300 --sink-uri="mysql://root:[email protected]:3306/" --changefeed-id="simple-replication-task"
🧹 Nitpick comments (3)
ticdc/ticdc-new-arch.md (3)
23-23: Typo in Description: Correct "这是一除示例".
There seems to be a typographical error in the Log Service description. Consider replacing “这是一除示例” with “这只是一个示例” (or a similar phrasing) for clarity.
82-82: Typo in Terminology: Correct "二进制文" to "二进制文件".
On line 82, “TiCDC 二进制文” appears to be a typographical mistake. Please change it to “TiCDC 二进制文件” for correctness.
114-114: Ordered List Style: Correct list numbering for consistency.
The ordered list item on line 114 starts with “3.” whereas previous items in the same list use “1.” and “2.”. For consistency and to follow markdown best practices (as flagged by MD029), please renumber this item appropriately.
A suggested diff:-3. 参考[恢复同步任务](/ticdc/ticdc-manage-changefeed.md#恢复同步任务)恢复所有的 Changefeed 同步任务； +1. 参考[恢复同步任务](/ticdc/ticdc-manage-changefeed.md#恢复同步任务)恢复所有的 Changefeed 同步任务；🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
114-114: Ordered list item prefix
Expected: 1; Actual: 3; Style: 1/2/3(MD029, ol-prefix)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ticdc/ticdc-new-arch.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
ticdc/ticdc-new-arch.md
114-114: Ordered list item prefix
Expected: 1; Actual: 3; Style: 1/2/3
(MD029, ol-prefix)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: pull
🔇 Additional comments (5)
ticdc/ticdc-new-arch.md (5)
17-17: Heading Clarity: Update "架构设" to "架构设计".
The heading “## 架构设” appears to be incomplete. For clarity and consistency, please change it to “## 架构设计”.
28-28: Heading Correction: Fix "新老架对比" to "新老架构对比".
Please update the heading to “## 新老架构对比” to fix the typo and maintain consistency.
50-50: Heading Consistency: Expand "新架" to "新架构".
In the heading “### 使用 TiUP 部署启用新架 TiCDC 的全新 TiDB 集群”, the term “新架” is abbreviated. For consistency with the rest of the document, please consider using “新架构”.
74-74: Heading Improvement: Clarify "升级为新架".
The heading “### 使用 TiUP 将原有 TiDB 集中的 TiCDC 升级为新架” would be clearer if updated to “升级为新架构”. This adjustment will improve clarity.
134-134: Heading Completeness: Update "注意事" to "注意事项".
The section heading “## 注意事” is incomplete. For clarity and consistency, please update it to “## 注意事项”.
| - 在 TiCDC 的老架构中，DDL 的同步是完全串行进行的，因此同步进度仅需通过 Changefeed 的 `CheckpointTs` 来标识。然而，在新架构中，为了提高 DDL 同步效率，TiCDC 会尽可能并行同步不同表的 DDL 变更。为了在下游 MySQL 兼容数据库中准确记录各表的 DDL 同步进度，TiCDC 新架构会在下游数据库中创建一张名为 `tidb_cdc.ddl_ts_v1` 的表，专门用于存储 Changefeed 的 DDL 同步进度信息。 | ||
| - 作为实验性特性，TiCDC v9.0 的新架尚未完全实现旧架构中的所有功能，这些功能将在后续的 GA 版本中完整实现，具体包括： |
There was a problem hiding this comment.
There is a typo in the text. The word '架构' is missing a character.
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
ticdc/ticdc-new-arch.md (1)
123-123:⚠️ Potential issueRemove Duplicate Command Invocation
The command on line 123 repeats "cdc cli changefeed create" twice. Please remove the duplicated text to avoid confusion:- cdc cli changefeed create cdc cli changefeed create --server=http://127.0.0.1:8300 --sink-uri="mysql://root:[email protected]:3306/" --changefeed-id="simple-replication-task" + cdc cli changefeed create --server=http://127.0.0.1:8300 --sink-uri="mysql://root:[email protected]:3306/" --changefeed-id="simple-replication-task"
🧹 Nitpick comments (4)
ticdc/ticdc-new-arch.md (4)
23-23: Clarify Log Service Description
The phrase "这是一除示例" on line 23 is unclear. Consider revising it to something like "这仅是一个示例" to improve readability.
50-51: Consistent Terminology for New Architecture
The document uses both "新架" and "新架构" (e.g., in the heading on line 50 and elsewhere). For clarity and consistency, standardize the terminology by using "新架构" throughout the document.
82-83: Typo in "二进制文"
There appears to be a typographical error on line 82. Please change "二进制文" to "二进制文件".
114-114: Standardize Ordered List Numbering
Markdown linting indicates an ordered list item prefix issue on line 114 ("3." instead of the expected "1."). If your style guideline recommends a uniform prefix (e.g., using "1." for all items), please update accordingly.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
114-114: Ordered list item prefix
Expected: 1; Actual: 3; Style: 1/2/3(MD029, ol-prefix)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ticdc/ticdc-new-arch.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
ticdc/ticdc-new-arch.md
114-114: Ordered list item prefix
Expected: 1; Actual: 3; Style: 1/2/3
(MD029, ol-prefix)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: pull
🔇 Additional comments (2)
ticdc/ticdc-new-arch.md (2)
17-17: Heading Correction: "架构设" → "架构设计"
The heading on line 17 appears truncated. For clarity and consistency, please update:-## 架构设 +## 架构设计
134-134: Heading Correction: "注意事" → "注意事项"
The heading on line 134 seems incomplete. Please update:-## 注意事 +## 注意事项
| ## 注意事 | ||
| - 在 TiCDC 的老架中，DDL 的同步是完全串进行的，因此同步进度仅需通过 Changefeed 的 `CheckpointTs` 来标。然而，在新架构中，为了提高 DDL 同步效率，TiCDC 会尽可能并行同步不同表的 DDL 变更。为了在下游 MySQL 兼容数据库中准确记录各表的 DDL 同步进度，TiCDC 新架构会在下游数据库中创建一张名为 `tidb_cdc.ddl_ts_v1` 的表，专门用于存储 Changefeed 的 DDL 同步进度信息。 |
There was a problem hiding this comment.
There are missing characters in the text. The words '老架构' and '串行' are incomplete, and '标识' is missing a character.
| - 在 TiCDC 的老架中，DDL 的同步是完全串进行的，因此同步进度仅需通过 Changefeed 的 `CheckpointTs` 来标。然而，在新架构中，为了提高 DDL 同步效率，TiCDC 会尽可能并行同步不同表的 DDL 变更。为了在下游 MySQL 兼容数据库中准确记录各表的 DDL 同步进度，TiCDC 新架构会在下游数据库中创建一张名为 `tidb_cdc.ddl_ts_v1` 的表，专门用于存储 Changefeed 的 DDL 同步进度信息。 | |
| - 在 TiCDC 的老架构中，DDL 的同步是完全串行进行的，因此同步进度仅需通过 Changefeed 的 `CheckpointTs` 来标识。然而，在新架构中，为了提高 DDL 同步效率，TiCDC 会尽可能并行同步不同表的 DDL 变更。为了在下游 MySQL 兼容数据库中准确记录各表的 DDL 同步进度，TiCDC 新架构会在下游数据库中创建一张名为 `tidb_cdc.ddl_ts_v1` 的表，专门用于存储 Changefeed 的 DDL 同步进度信息。 |
4 participants
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?
Summary by CodeRabbit