test0308 #7
test0308 #7
Conversation
|
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| ### end-point-memory-quota <span class="version-mark">从 v8.2.0 版本开始引入</span> | ||
|
|
||
| * TiKV Coproccessor 请求可以使用的内存上限，超过该值后后续的 Coprocessor 请求将被拒绝并报错（server is busy）。 |
There was a problem hiding this comment.
The description of end-point-memory-quota is unclear and lacks context. It should explicitly mention that this configuration controls the memory usage limit for Coprocessor requests and what happens when the limit is exceeded. Additionally, the error message should be clarified.
| * TiKV Coproccessor 请求可以使用的内存上限，超过该值后后续的 Coprocessor 请求将被拒绝并报错（server is busy）。 | |
| * TiKV Coprocessor 请求可以使用的内存上限。当内存使用超过该限制时，后续的 Coprocessor 请求将被拒绝，并返回错误信息 `server is busy`。 |
| ## txn-status-cache-capacity <span class="version-mark">从 v7.6.0 版本开始引入</span> | ||
|
|
||
| + 设置 TiKV 内的事务状态 cache 的容量。不建议用户随意修改。 |
There was a problem hiding this comment.
The description for txn-status-cache-capacity is too vague and does not provide enough context for users to understand its purpose or implications. It should clarify what the cache is used for and why modifying it is not recommended.
| + 设置 TiKV 内的事务状态 cache 的容量。不建议用户随意修改。 | |
| + 设置 TiKV 内的事务状态缓存（Transaction Status Cache）的容量。该缓存用于存储事务状态信息，以提高事务处理的性能。不建议用户随意修改，因为不合理的配置可能导致性能下降或内存使用过高。 |
|
|
||
| ### follower-read-max-log-gap <span class="version-mark">从 v7.4.0 版本开始引入</span> | ||
|
|
||
| + follower 处理读请求时允许的最大日志落后数目，超出则拒绝读请求。 |
There was a problem hiding this comment.
The description of follower-read-max-log-gap is unclear. It should explicitly mention that this parameter is related to Raft logs and specify the unit of the value (e.g., number of logs).
| + follower 处理读请求时允许的最大日志落后数目，超出则拒绝读请求。 | |
| + follower 处理读请求时允许的最大 Raft 日志落后数目（以日志条数为单位），超出则拒绝读请求。 |
|
|
||
| ### inspect-kvdb-interval <span class="version-mark">从 v8.1.2 版本开始引入</span> | ||
|
|
||
| + TiKV 进行慢节点检测时检查 KV 盘的间隔和超时时间。如果 KVDB 和 RaftDB 使用相同的挂载路径，该值将被覆盖为 0（不检测）。 |
There was a problem hiding this comment.
The description of inspect-kvdb-interval is ambiguous. It should clarify what happens when KVDB and RaftDB use the same mount path and why the value is overridden to 0.
| + TiKV 进行慢节点检测时检查 KV 盘的间隔和超时时间。如果 KVDB 和 RaftDB 使用相同的挂载路径，该值将被覆盖为 0（不检测）。 | |
| + TiKV 进行慢节点检测时检查 KV 盘的间隔和超时时间。如果 KVDB 和 RaftDB 使用相同的挂载路径，该值将被覆盖为 0（不检测），以避免重复检测。 |
|
|
||
| ### min-pending-apply-region-count <span class="version-mark">从 v8.0.0 版本开始引入</span> | ||
|
|
||
| + TiKV 启动服务时，处于忙于应用 Raft 日志状态的 Region 的最大个数。只有当忙于应用 Raft 日志的 Region 数量低于该值时，Raftstore 才能接受 leader 迁移，以减少滚动重启期间的可用性下降。 |
There was a problem hiding this comment.
The description of min-pending-apply-region-count is confusing. It should clarify that this parameter is used during TiKV startup and its purpose is to ensure availability during rolling restarts.
| + TiKV 启动服务时，处于忙于应用 Raft 日志状态的 Region 的最大个数。只有当忙于应用 Raft 日志的 Region 数量低于该值时，Raftstore 才能接受 leader 迁移，以减少滚动重启期间的可用性下降。 | |
| + TiKV 启动服务时，处于忙于应用 Raft 日志状态的 Region 的最大个数。只有当忙于应用 Raft 日志的 Region 数量低于该值时，Raftstore 才能接受 leader 迁移，以减少滚动重启期间的可用性下降。 |
|
|
||
| ### enable-multi-batch-write <span class="version-mark">从 v6.2.0 版本开始引入</span> | ||
|
|
||
| + 开启 RocksDB 写入优化，将 WriteBatch 中的内容并发写入到 memtable 中，缩短写入耗时。 |
There was a problem hiding this comment.
The description of enable-multi-batch-write could be more precise. It should clarify that the optimization is specifically for concurrent writes to the memtable, which reduces write latency.
| + 开启 RocksDB 写入优化，将 WriteBatch 中的内容并发写入到 memtable 中，缩短写入耗时。 | |
| + 开启 RocksDB 写入优化，将 WriteBatch 中的内容并发写入到 memtable 中，从而减少写入延迟。 |
|
|
||
| ### `max-compactions` <span class="version-mark">从 v6.6.0 版本开始引入</span> | ||
|
|
||
| + 最大 compaction 任务并发数。0 表示不限制。 |
There was a problem hiding this comment.
The description of max-compactions is unclear. It should specify whether this configuration applies to all compaction tasks or specific types of compaction tasks (e.g., manual or automatic). Additionally, it should mention the potential impact on system performance when setting this value.
| + 最大 compaction 任务并发数。0 表示不限制。 | |
| + 最大 compaction 任务并发数。0 表示不限制。该配置适用于所有 compaction 任务。设置过高的值可能会增加系统负载，影响性能。 |
|
|
||
| ### `compression-level` <span class="version-mark">从 v7.4.0 版本开始引入</span> | ||
|
|
||
| + 设置 raft-engine 在写 raft log 文件时所采用的 lz4 压缩算法的压缩效率，范围 [1, 16]，越低压缩速率越高，但压缩率越低。 |
There was a problem hiding this comment.
The description of compression-level is unclear and could be misleading. The phrase '越低压缩速率越高，但压缩率越低' is ambiguous. It should clearly state the trade-off between compression speed and compression ratio.
| + 设置 raft-engine 在写 raft log 文件时所采用的 lz4 压缩算法的压缩效率，范围 [1, 16]，越低压缩速率越高，但压缩率越低。 | |
| + 设置 raft-engine 在写 raft log 文件时所采用的 lz4 压缩算法的压缩效率，范围 [1, 16]。值越低，压缩速度越快，但压缩后的文件大小越大；值越高，压缩速度越慢，但压缩后的文件大小越小。 |
| + 是否开启内存引擎以加速多版本查询。关于内存引擎的详细信息，参见 [TiKV MVCC 内存引擎](/tikv-in-memory-engine.md)。 | ||
| + 默认值：false（即关闭内存引擎） | ||
| + 建议 TiKV 节点至少配置 8 GiB 内存，推荐配置 32 GiB 或更多内存以获得更佳性能。 |
There was a problem hiding this comment.
The sentence about memory configuration is unclear and lacks context. It should specify whether the memory requirement is per TiKV node or for the entire cluster. Additionally, it should clarify if this is a minimum requirement or a recommendation for optimal performance.
| + 建议 TiKV 节点至少配置 8 GiB 内存，推荐配置 32 GiB 或更多内存以获得更佳性能。 | |
| + 建议每个 TiKV 节点至少配置 8 GiB 内存，推荐配置 32 GiB 或更多内存以获得更佳性能。 |
| + 是否开启内存引擎以加速多版本查询。关于内存引擎的详细信息，参见 [TiKV MVCC 内存引擎](/tikv-in-memory-engine.md)。 | ||
| + 默认值：false（即关闭内存引擎） | ||
| + 建议 TiKV 节点至少配置 8 GiB 内存，推荐配置 32 GiB 或更多内存以获得更佳性能。 | ||
| + 如果 TiKV 可用内存过低，即使将该配置项设置为 `true`，内存引擎也不会被启用。此时，你可以在 TiKV 的日志文件中查找与 `"in-memory engine is disabled because"` 相关的日志信息，以判断为何内存引擎未能启用。 |
There was a problem hiding this comment.
The sentence about low memory conditions could be more precise. It should explicitly state that the memory engine will not be enabled if the available memory is below a certain threshold, and it should specify what that threshold is.
| + 如果 TiKV 可用内存过低，即使将该配置项设置为 `true`，内存引擎也不会被启用。此时，你可以在 TiKV 的日志文件中查找与 `"in-memory engine is disabled because"` 相关的日志信息，以判断为何内存引擎未能启用。 | |
| + 如果 TiKV 节点的可用内存低于 8 GiB，即使将该配置项设置为 `true`，内存引擎也不会被启用。此时，你可以在 TiKV 的日志文件中查找与 `"in-memory engine is disabled because"` 相关的日志信息，以判断为何内存引擎未能启用。 |
2 participants
temperature: 0.3
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?