This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for all your great work @qianguih and @jeasinema. I found it useful to generalize the setup.py to look for the numpy headers when building the extension. Without this, user might need to manually set where the numpy numpy/arrayobject.h file is, which can be tricky in the virtual env. This should make it more robust. Tested on the University of Florida computing cluster.
Running
inside a conda env.