Merge branch 'fix_flux_fit' into fit_flux_matrix

src/qibocal/cli/fit.py

@@ -47,7 +47,9 @@ def fit(path, update):
     # dump updated runcard
     if platform is not None and update:  # pragma: no cover
         # cannot test update since dummy may produce wrong values and trigger errors
+        (path / UPDATED_PLATFORM).mkdir(parents=True, exist_ok=True)
         dump_runcard(platform, path / UPDATED_PLATFORM)
 
     # dump json
+
     (path / META).write_text(json.dumps(meta, indent=4))

src/qibocal/protocols/characterization/flux_dependence/utils.py

@@ -403,6 +403,6 @@ def resonator_flux_dependence_fit_bounds(
     left_bound, right_bound = qubit_flux_dependence_fit_bounds(
         qubit_frequency=qubit_frequency, bias=bias
     )
-    left_bound += [bare_resonator_frequency - 0.5, 0]
-    right_bound += [bare_resonator_frequency + 0.5, 1]
+    left_bound += [bare_resonator_frequency * HZ_TO_GHZ - 0.5, 0]
+    right_bound += [bare_resonator_frequency * HZ_TO_GHZ + 0.5, 1]
     return (left_bound, right_bound)

tests/test_protocols.py

@@ -95,8 +95,9 @@ def test_acquire_command(runcard, backend, platform, tmp_path):
     assert results_report.exit_code == 0
 
 
+@pytest.mark.parametrize("update", ["--update", "--no-update"])
 @pytest.mark.parametrize("runcard", generate_runcard_single_protocol(), ids=idfn)
-def test_fit_command(runcard, tmp_path):
+def test_fit_command(runcard, update, tmp_path):
     """Test fit builder and report generated."""
     (tmp_path / SINGLE_ACTION_RUNCARD).write_text(yaml.safe_dump(runcard))
     runner = CliRunner()
@@ -116,7 +117,7 @@ def test_fit_command(runcard, tmp_path):
     assert results.exit_code == 0
 
     # perform fit
-    results_fit = runner.invoke(command, ["fit", str(tmp_path), "--no-update"])
+    results_fit = runner.invoke(command, ["fit", str(tmp_path), update])
 
     assert not results_fit.exception
     assert results_fit.exit_code == 0