WIP : adding in shaply values #221
Conversation
|
Hi @mortonjt, thanks for your work on this! Is this something you'd like to see in the 2022.11 release? Our PR submission cutoff is this Friday, so we can get this added to the board if you think it'll be ready for review by Nov. 10th (our PR merge cutoff date). |
|
Hi Liz, thanks for your interest — unfortunately I don't think we can hit
that deadline. But we can try to hit the next one.
…On Tue, Nov 1, 2022 at 6:16 PM Liz Gehret ***@***.***> wrote:
Hi @mortonjt <https://github.com/mortonjt>, thanks for your work on this!
Is this something you'd like to see in the 2022.11 release? Our PR
submission cutoff is this Friday, so we can get this added to the board if
you think it'll be ready for review by Nov. 10th (our PR merge cutoff date).
—
Reply to this email directly, view it on GitHub
<#221 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA75VXK2QKRY64EHRY5XET3WGGJCJANCNFSM6AAAAAARTLXZM4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@mortonjt sounds good! I'll get this added to our future release board. Let us know when it's ready for review. 🙂 |
|
Hi, @mortonjt and I made this work, it's available here https://github.com/jindongmin/q2-sample-classifier.git. Thanks! |
|
Hi @jindongmin thanks for the update! Can you either add your changes to this PR or open up a new one for our team to review? @mortonjt just FYI we ended up pushing back our 2022.11 release until December 15th, so we could still add this to that release if things are almost ready here! |
|
Hey @mortonjt @adamovanja we're going to go ahead and close this PR as well, in conjunction with this PR that we closed recently. Feel free to reach out if either of you have the bandwidth and interest to pick them back up though! |
This is a preliminary pull request to add shapely values #219
Things will probably break for now.
To install this branch, run
pip install git+https://github.com/mortonjt/q2-sample-classifier.gitOf course, make sure to run
qiime dev refresh-cacheafter installation.