Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/xrobot/mcp/example-music-pan.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ AK 与 SK 是重要隐私,避免泄露给不可信来源。

来到灵矽AI控制台,登录之后,点击左侧的侧边栏选项“自定义MCP”,然后点击“添加自定义MCP”。

在弹出的对话框中你需要按照表单填写服务名称、简短描述、LOGO、tag,以及接入配置,接入配置填写需要注意,你是以服务提供者的身份填写信息,不是以使用者的身份填写信息:
在弹出的对话框中你需要按照表单填写服务名称、简短描述、LOGO、tag,以及接入配置,接入配置填写需要注意,你是以**服务提供者**的身份填写信息,不是以使用者的身份填写信息:

- SSE URL: 需要填写完整的,带有http(s)协议的、可访问的URL,通常还是以/SSE结尾

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty Section - Needs Completion

This section shows "暂无" (none/unavailable) but the document provides detailed deployment instructions. Either:

  1. Provide the actual repository URL
  2. Clarify when code will be available (e.g., "代码仓库即将开放")
  3. Remove this section if the code is not publicly available

Expand Down Expand Up @@ -184,4 +184,4 @@ AK 与 SK 是重要隐私,避免泄露给不可信来源。

<!-- [七牛云对象存储 - 开发者文档](https://developer.qiniu.com/kodo) -->

当前 music-mcp-server SSE URL:`http://121.29.19.158:8000/sse`
当前 music-mcp-server SSE URL:`http://121.29.19.146:8000/sse`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

在文档中硬编码IP地址 (121.29.19.146) 不是一个好的实践,因为它可能会发生变化,导致文档过时。建议使用一个占位符 (例如 your-server-ipexample.com) 或者一个稳定的域名来代替,以提高文档的长期可用性和可维护性。

Suggested change
当前 music-mcp-server SSE URL:`http://121.29.19.146:8000/sse`
当前 music-mcp-server SSE URL:`http://<your-server-ip>:8000/sse`

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Concern: Hardcoded HTTP Endpoint

This hardcoded public IP address with HTTP (not HTTPS) protocol poses security risks:

  1. Credentials in headers (AK/SK) transmitted unencrypted over HTTP
  2. IP addresses may change, making documentation outdated
  3. Exposes internal infrastructure

Recommendations:

  • Use HTTPS instead of HTTP for production
  • Add warning that this is example/test URL only
  • Document that users should deploy their own instances
  • Consider using a domain name instead of raw IP

16 changes: 15 additions & 1 deletion docs/xrobot/platform/blufi-config.md
Original file line number Diff line number Diff line change
Expand Up @@ -172,12 +172,26 @@ sequenceDiagram

### 2.2 设备识别

**设备名称规则**: 设备名称应匹配以下模式之一
**设备名称规则**: 设备名称name应匹配以下模式之一

- `DTXZ*`
- `BLUFI_DEVICE*`
- `ESP_*`

**设备MAC地址获取**: 设备在广播时发送,客户端与设备连接前获取:

1. 通常可以直接通过广播发现设备时的数据包的deviceId获取
2. 由于一些[安全机制](https://developers.weixin.qq.com/miniprogram/dev/framework/device/bluetooth.html),IOS不适用第一条(无法正常获取设备MAC地址)

解决方案:约定将设备MAC地址设置在`localName`中,参考[微信小程序文档](https://developers.weixin.qq.com/miniprogram/dev/api/device/bluetooth/wx.onBluetoothDeviceFound.html)

MAC地址格式可以是
- AA:BB:CC:DD:EE:FF
- AA-BB-CC-DD-EE-FF
- AABBCCDDEEFF

满足正则`/[0-9A-Fa-f]{2}([-:]?)[0-9A-Fa-f]{2}(?:\1[0-9A-Fa-f]{2}){4}$/`即可(注意$),建议直接使用第一种,设备与智能体绑定所使用的MAC地址格式也为第一种。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regex Pattern Missing Start Anchor

The MAC address validation regex lacks a start anchor ^, which could allow malicious input with valid MAC addresses appended.

Suggested change
满足正则`/[0-9A-Fa-f]{2}([-:]?)[0-9A-Fa-f]{2}(?:\1[0-9A-Fa-f]{2}){4}$/`即可(注意$),建议直接使用第一种设备与智能体绑定所使用的MAC地址格式也为第一种。
满足正则`/^[0-9A-Fa-f]{2}([-:]?)[0-9A-Fa-f]{2}(?:\1[0-9A-Fa-f]{2}){4}$/`即可(注意$),建议直接使用第一种,设备与智能体绑定所使用的MAC地址格式也为第一种。


**连接模式**:

- 设备作为外围设备(Peripheral)进行广播
Expand Down