Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix report type with correct platform #464

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

CarlJi
Copy link
Contributor

@CarlJi CarlJi commented Nov 27, 2024

No description provided.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for reviewbot-x canceled.

Name Link
🔨 Latest commit 4c93b5f
🔍 Latest deploy log https://app.netlify.com/sites/reviewbot-x/deploys/674696cc17173600080d23ef

@@ -268,7 +268,7 @@ func (g *GitlabProvider) Report(ctx context.Context, a Agent, lintResults map[st
orgRepo := fmt.Sprintf("%s/%s", org, repo)
reportFormat := reportFormatMatCheck(g.GitLabClient, a.LinterConfig.ReportType)
switch reportFormat {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] reported by reviewbot🐮
missing cases in switch of type config.ReportType: config.GitHubCheckRuns, config.GitHubPRReview, config.GitHubMixType (exhaustive)

@@ -64,7 +64,7 @@ type Agent struct {
// getMsgFormat returns the message format based on report type.
func getMsgFormat(format config.ReportType) string {
switch format {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] reported by reviewbot🐮
missing cases in switch of type config.ReportType: config.GitHubCheckRuns, config.GitLabComment, config.GitLabCommentAndDiscussion, config.Quiet (exhaustive)

@@ -296,7 +296,7 @@ func (g *GithubProvider) Report(ctx context.Context, a Agent, lintResults map[st
orgRepo := fmt.Sprintf("%s/%s", org, repo)

switch a.LinterConfig.ReportType {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci-lint] reported by reviewbot🐮
missing cases in switch of type config.ReportType: config.GitLabComment, config.GitLabCommentAndDiscussion (exhaustive)

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 22.72727% with 17 lines in your changes missing coverage. Please review.

Project coverage is 25.11%. Comparing base (68b541c) to head (4c93b5f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/linters/providergitlab.go 0.00% 5 Missing ⚠️
internal/linters/providergithub.go 0.00% 3 Missing ⚠️
server.go 0.00% 3 Missing ⚠️
clone.go 0.00% 2 Missing ⚠️
main.go 0.00% 2 Missing ⚠️
config/config.go 75.00% 1 Missing ⚠️
internal/linters/go/gofmt/gofmt.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #464   +/-   ##
=======================================
  Coverage   25.11%   25.11%           
=======================================
  Files          32       32           
  Lines        4599     4599           
=======================================
  Hits         1155     1155           
  Misses       3305     3305           
  Partials      139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CarlJi CarlJi merged commit 568d241 into qiniu:master Nov 27, 2024
7 of 8 checks passed
@CarlJi CarlJi deleted the feat/token branch November 27, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant