-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix report type with correct platform #464
Conversation
✅ Deploy Preview for reviewbot-x canceled.
|
@@ -268,7 +268,7 @@ func (g *GitlabProvider) Report(ctx context.Context, a Agent, lintResults map[st | |||
orgRepo := fmt.Sprintf("%s/%s", org, repo) | |||
reportFormat := reportFormatMatCheck(g.GitLabClient, a.LinterConfig.ReportType) | |||
switch reportFormat { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golangci-lint] reported by reviewbot🐮
missing cases in switch of type config.ReportType: config.GitHubCheckRuns, config.GitHubPRReview, config.GitHubMixType (exhaustive)
@@ -64,7 +64,7 @@ type Agent struct { | |||
// getMsgFormat returns the message format based on report type. | |||
func getMsgFormat(format config.ReportType) string { | |||
switch format { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golangci-lint] reported by reviewbot🐮
missing cases in switch of type config.ReportType: config.GitHubCheckRuns, config.GitLabComment, config.GitLabCommentAndDiscussion, config.Quiet (exhaustive)
@@ -296,7 +296,7 @@ func (g *GithubProvider) Report(ctx context.Context, a Agent, lintResults map[st | |||
orgRepo := fmt.Sprintf("%s/%s", org, repo) | |||
|
|||
switch a.LinterConfig.ReportType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golangci-lint] reported by reviewbot🐮
missing cases in switch of type config.ReportType: config.GitLabComment, config.GitLabCommentAndDiscussion (exhaustive)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #464 +/- ##
=======================================
Coverage 25.11% 25.11%
=======================================
Files 32 32
Lines 4599 4599
=======================================
Hits 1155 1155
Misses 3305 3305
Partials 139 139 ☔ View full report in Codecov by Sentry. |
No description provided.