Combine counters #103
Open
Combine counters #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrossinek
reviewed
Sep 2, 2024
mrossinek
reviewed
Sep 12, 2024
Comment on lines
+75
to
+77
| combine_counts: indicates, when applicable, whether to combine the counts associated | ||
| with different parameter values that were submitted for a single parametrized | ||
| circuit. |
There was a problem hiding this comment.
I think this explanation has to be extended further:
- we should clarify what "when applicable" means
- we should clarify that and how we use
np.ndarray.flatten - we should have a clear example what this implies for 0d-, 1d-, and Nd- arrays of parameters in the original job
We can either do that in the docs here, or in a how-to guide and link to that from here (which may be better as it gives us more space for explanations).
Comment on lines
+94
to
+96
| combine_counts: indicates, when applicable, whether to combine the counts associated | ||
| with different parameter values that were submitted for a single parametrized | ||
| circuit. |
There was a problem hiding this comment.
This needs to be aligned with whatever updates we apply based on the previous comment.
Comment on lines
+4
to
+5
| Add an option for the post-processors to combine the counts associated with different parameter | ||
| values that were submitted in the same POVM sampler PUB. |
There was a problem hiding this comment.
If we do end up with a new how-to guide, we should link to that from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option for the post-processors to combine the counts associated with different parameter values that were submitted in the same POVM sampler PUB.