Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qubit specifier #18

Merged
merged 12 commits into from
May 22, 2024
Merged

Qubit specifier #18

merged 12 commits into from
May 22, 2024

Conversation

timmintam
Copy link
Collaborator

Offer the possibility to the user to specify on which qubits a POVMImplementation instance should act (possibly not on all qubits for instance).

Closes #15

@timmintam timmintam marked this pull request as ready for review May 21, 2024 11:45
@timmintam timmintam requested a review from mrossinek as a code owner May 21, 2024 11:45
Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. Some suggestions on the how-to guide, otherwise some naming.

@timmintam timmintam requested a review from mrossinek May 21, 2024 15:34
Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@timmintam timmintam merged commit 5dd2ef2 into main May 22, 2024
8 checks passed
@timmintam timmintam deleted the qubit_specifier branch May 22, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qubit specifier for POVM implementations
2 participants