This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Updated analysis.py to fix for issue#511(Wrong arguments) #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for issue#511. The issue mentions that the error mitigated fidelity should be composed of P0, P1, and C, not P0_m, P1_m, and C. But in line 192, for the Fourier Analysis, we don't have to apply the mitigated values for the first term. Hence the changes have been made. The arguments P0_m and P1_m have been changed to P0 and P1.
Details and comments
This updates have been made in the understanding that issue has a valid point. This is my first contribution for this project. Please Review and let me know if am wrong.