-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Issue-181 | Prepare for summer school release #182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this merges I'll populate the secrets for gha so that we'll be able to publish artifacts when it comes time to actually release.
.github/workflows/pypi-release.yml
Outdated
TWINE_USERNAME: qiskit | ||
run : | | ||
pip install -U twine pip setuptools virtualenv wheel | ||
python3 setup.py sdist bdist_wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is a c++ extension in the package this won't be portable and isn't something you should publish as it will depend on the system libraries versions. You should leverage cibuildwheel here to build portable wheels of the package for distribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtreinish How do we test different distros for aer for example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't really have to test with different distros in CI, that's what cibuildwheel is for. It builds the binaries in the manylinux docker image to ensure the glibc and other libraries are at old enough versions (by basically just using red hat which is always the oldest) and then auditwheel is used to statically link any dynamic libs and check the symbols are compatible with the manylinux packaging specs and update the wheel tags. If you configure cibiuldwheel correctly and have it run tests of the wheels it should be sufficient to have confidence it will work in any environment that is compatible with the manylinux tags
# Push to qiskit.org website | ||
openssl aes-256-cbc -K $encrypted_rclone_key -iv $encrypted_rclone_iv -in tools/rclone.conf.enc -out $RCLONE_CONFIG_PATH -d | ||
echo "Pushing built docs to website" | ||
rclone sync --progress --exclude locale/** ./docs/_build/html IBMCOS:qiskit-org-web-resources/documentation/qec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to update https://github.com/Qiskit/qiskit/blob/master/tools/other-builds.txt so that qiskit doc builds won't delete the qec docs.
Also you should check the requirements list before release too. I noticed that |
The |
This issue is repurposed to prep works for summer school. |
Summary
Prepare for summer school
TODOs: