Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpp check nodes #420

Merged
merged 63 commits into from
Feb 19, 2024
Merged

Cpp check nodes #420

merged 63 commits into from
Feb 19, 2024

Conversation

quantumjim
Copy link
Member

@quantumjim quantumjim commented Feb 14, 2024

Summary

The check_nodes and is_cluster_neutral methods of ArcCircuit are reimplemented in C++.

@quantumjim
Copy link
Member Author

I'd like to put a limit on this loop. @tommasopeduzzi Do you think the following would be enough?

        j = 0
        while self.odd_cluster_roots and j < 2 * self.code.d * (self.code.T + 1):
            self._grow_and_merge_clusters()
            j += 1

Or not enough? Or too much?

@tommasopeduzzi
Copy link
Contributor

I'd like to put a limit on this loop. @tommasopeduzzi Do you think the following would be enough?

        j = 0
        while self.odd_cluster_roots and j < 2 * self.code.d * (self.code.T + 1):
            self._grow_and_merge_clusters()
            j += 1

Or not enough? Or too much?

Shouldn't be neccessary in theory, but the way you do it seems good to me.

@quantumjim quantumjim marked this pull request as ready for review February 19, 2024 08:50
Copy link
Collaborator

@grace-harper grace-harper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grace-harper grace-harper merged commit fb8d9fa into main Feb 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants