Skip to content

Commit

Permalink
[QOLDEV-915] fix handling of schema_upload field
Browse files Browse the repository at this point in the history
- Attach a file rather than entering a string
  • Loading branch information
ThrawnCA committed Jul 16, 2024
1 parent b0023c3 commit e3ce583
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/features/data_usability_rating.feature
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Feature: Data usability rating
Scenario: As a publisher, when I create an open resource with a matching schema, I can verify the score is upgraded from 3 to 4
Given "TestOrgEditor" as the persona
When I log in
And I create a dataset and resource with key-value parameters "license=other-open" and "format=CSV::upload=csv_resource_with_schema.csv::schema_upload=test-resource_schemea.json"
And I create a dataset and resource with key-value parameters "license=other-open" and "format=CSV::upload=test_game_data.csv::schema=default"
And I press the element with xpath "//ol[contains(@class, 'breadcrumb')]//a[starts-with(@href, '/dataset/')]"
And I reload page every 3 seconds until I see an element with xpath "//div[contains(@class, 'qa') and contains(@class, 'openness-')]" but not more than 10 times
Then I should see an element with xpath "//div[contains(@class, 'openness-4')]"
Expand Down
16 changes: 15 additions & 1 deletion test/features/steps/steps.py
Original file line number Diff line number Diff line change
Expand Up @@ -294,14 +294,22 @@ def fill_in_default_link_resource_fields(context):
@when(u'I upload "{file_name}" of type "{file_format}" to resource')
def upload_file_to_resource(context, file_name, file_format):
context.execute_steps(u"""
When I execute the script "$('#resource-upload-button').trigger(click);"
When I execute the script "$('#resource-upload-button').trigger('click');"
And I attach the file "{file_name}" to "upload"
# Don't quote the injected string since it can have trailing spaces
And I execute the script "document.getElementById('field-format').value='{file_format}'"
And I fill in "size" with "1024" if present
""".format(file_name=file_name, file_format=file_format))


@when(u'I upload schema file "{file_name}" to resource')
def upload_schema_file_to_resource(context, file_name):
context.execute_steps(u"""
When I execute the script "$('#field-schema-json ~ a.btn-remove-url').trigger('click');"
And I attach the file "{file_name}" to "schema_upload"
""".format(file_name=file_name))


@when(u'I go to group page')
def go_to_group_page(context):
context.execute_steps(u"""
Expand Down Expand Up @@ -527,6 +535,12 @@ def create_resource_from_params(context, resource_params):
if value == "default":
value = resource_default_schema
_enter_manual_schema(context, value)
elif key == "schema_upload":
if value == "default":
value = "test-resource_schemea.json"
context.execute_steps(u"""
When I upload schema file "{0}" to resource
""".format(value))
else:
context.execute_steps(u"""
When I fill in "{0}" with "{1}" if present
Expand Down

0 comments on commit e3ce583

Please sign in to comment.