Develop to master - fix integration with QA plugin #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previously we detected the QA plugin presence by checking for it in the config, but this has stopped working, possibly as part of the CKAN 2.10 upgrade. Change it to instead attempt the necessary imports and rely on that. NB This will cause ckanext-data-qld to implement the IQA interface if QA is installed but not enabled. However, that should not be problematic, since the interface will simply do nothing if QA is not running.
- Attach a file rather than entering a string
- We need to update ckanext-validation in order to update Click
…ating QOLDEV-915 fix usability rating for CSV resources with valid schemas
duttonw
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSV resources with valid schemas should have data usability rating 4 instead of 3. The custom rating function was broken by the CKAN 2.10 upgrade.