Develop to master - prepare for CKAN 2.11 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Interface for data pipeline after validation reports.
- Add `IPipeValidation` implementation into test class.
- Set correct plugin calls for new implement.
…erafce IPipeValidation Interface
chore: merge upstream
…_session instead of string as python3 is more strict
…less Chore: swap goodtables to frictionless
- Ensure shell variables are escaped - Add reporting-only testing on CKAN 2.11 and latest master - Prepare scenario tests for CKAN 2.11
…ation into QOLDEV-1013-ckan-2.11
- Also drop obsolete Python 2 support and prepare for newer test containers
- Only trigger on pull requests if they're going to master
- Use our custom upload step that handles the idiosyncrasies of the CKAN upload interface
- We no longer have any CKAN 2.9 environment to perform manual testing, and it's officially unsupported
- 'Manage' button text is changing, identify it by URL instead
- Keep 'init_tables' to make it compatible with CKAN 2.11+
chore: enable dependabot and nice release notes
…ext-validation into QOLDEV-1013-ckan-2.11
QOLDEV-1013 prepare for CKAN 2.11
ThrawnCA
commented
Jan 6, 2025
| @@ -6,8 +6,7 @@ <h1 class="page-heading">{{ h.resource_display_name(res) | truncate(50) }} | |||
| {{ h.get_validation_badge(res)|safe }} | |||
| </h1> | |||
|
|
|||
| {% set type = 'asset' %} | |||
| {% include 'validation/snippets/validation_style_' ~ type ~ '.html' %} | |||
| {% include 'validation/snippets/validation_report_asset.html' %} | |||
There was a problem hiding this comment.
@duttonw Is this the correct replacement for validation_style_asset.html?
chris-randall-qol
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.pywithpyproject.toml